[PATCH] ARM: mach-footbridge: add missing header file <video/vga.h>

[PATCH] ARM: mach-footbridge: add missing header file <video/vga.h>

[Bryan Wu]

This patch fixes following building error:
--
arch/arm/mach-footbridge/dc21285.c: In function 'dc21285_preinit':
arch/arm/mach-footbridge/dc21285.c:299:2: error: 'vga_base' undeclared (first use in this function)
arch/arm/mach-footbridge/dc21285.c:299:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [arch/arm/mach-footbridge/dc21285.o] Error 1
--

Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
---
 arch/arm/mach-footbridge/dc21285.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-footbridge/dc21285.c b/arch/arm/mach-footbridge/dc21285.c
index 1331fff..18c32a5 100644
--- a/arch/arm/mach-footbridge/dc21285.c
+++ b/arch/arm/mach-footbridge/dc21285.c
@@ -18,6 +18,7 @@
 #include <linux/irq.h>
 #include <linux/io.h>
 #include <linux/spinlock.h>
+#include <video/vga.h>
 
 #include <asm/irq.h>
 #include <asm/system.h>
-- 
1.7.5

[PATCH] ARM: mach-footbridge: add missing header file <video/vga.h>

[Bryan Wu]

Russell,

Also this one. any comment?

Thanks,
-Bryan

On Wed, Aug 17, 2011 at 6:00 PM, Bryan Wu <bryan.wu@canonical.com> wrote:
> This patch fixes following building error:
> --
> arch/arm/mach-footbridge/dc21285.c: In function 'dc21285_preinit':
> arch/arm/mach-footbridge/dc21285.c:299:2: error: 'vga_base' undeclared (first use in this function)
> arch/arm/mach-footbridge/dc21285.c:299:2: note: each undeclared identifier is reported only once for each function it appears in
> make[1]: *** [arch/arm/mach-footbridge/dc21285.o] Error 1
> --
>
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
> ---
> ?arch/arm/mach-footbridge/dc21285.c | ? ?1 +
> ?1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-footbridge/dc21285.c b/arch/arm/mach-footbridge/dc21285.c
> index 1331fff..18c32a5 100644
> --- a/arch/arm/mach-footbridge/dc21285.c
> +++ b/arch/arm/mach-footbridge/dc21285.c
> @@ -18,6 +18,7 @@
> ?#include <linux/irq.h>
> ?#include <linux/io.h>
> ?#include <linux/spinlock.h>
> +#include <video/vga.h>
>
> ?#include <asm/irq.h>
> ?#include <asm/system.h>
> --
> 1.7.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>



-- 
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer ? ?+86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd. ? ? ?www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com

[PATCH] ARM: mach-footbridge: add missing header file <video/vga.h>

[Russell King - ARM Linux]

On Fri, Aug 19, 2011 at 12:37:09PM +0800, Bryan Wu wrote:
> Russell,
> 
> Also this one. any comment?

Other than frustration that Rob Herring isn't responding to his breakage
(which is making me want to ignore further patches from Rob - clearly
doesn't care about the effect of his c9d95fb "ARM: convert PCI defines
to variables" patch...)

It looks obviously correct.

[PATCH] ARM: mach-footbridge: add missing header file <video/vga.h>

[Bryan Wu]

On Sun, Aug 21, 2011 at 4:41 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Fri, Aug 19, 2011 at 12:37:09PM +0800, Bryan Wu wrote:
>> Russell,
>>
>> Also this one. any comment?
>
> Other than frustration that Rob Herring isn't responding to his breakage
> (which is making me want to ignore further patches from Rob - clearly
> doesn't care about the effect of his c9d95fb "ARM: convert PCI defines
> to variables" patch...)
>

I forgot to add Rob in this email loop. Added now.

> It looks obviously correct.
>

Thanks,
-- 
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer ? ?+86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd. ? ? ?www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com

[PATCH] ARM: mach-footbridge: add missing header file <video/vga.h>

[Rob Herring]

On 08/21/2011 10:36 AM, Bryan Wu wrote:
> On Sun, Aug 21, 2011 at 4:41 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
>> On Fri, Aug 19, 2011 at 12:37:09PM +0800, Bryan Wu wrote:
>>> Russell,
>>>
>>> Also this one. any comment?
>>
>> Other than frustration that Rob Herring isn't responding to his breakage
>> (which is making me want to ignore further patches from Rob - clearly
>> doesn't care about the effect of his c9d95fb "ARM: convert PCI defines
>> to variables" patch...)
>>

Sorry, I've been away on vacation Wed-Sat.

> 
> I forgot to add Rob in this email loop. Added now.

Thanks for copying me directly.

> 
>> It looks obviously correct.
>>

I went back to check for other instances and found orion5x is also
broken missing this include. It is also broken by another commit which
I'll fix. Patches coming soon.

Rob