From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] ARM: l2x0: add empty l2x0_of_init
Date: Wed, 31 Aug 2011 22:58:13 -0500 [thread overview]
Message-ID: <4E5F02D5.6030508@gmail.com> (raw)
In-Reply-To: <CAGsJ_4zS8qA-rD+NQzUo58J8pT+-4uhrCdHCKgkCJxX30KY3Ag@mail.gmail.com>
Barry,
On 08/31/2011 10:36 PM, Barry Song wrote:
> 2011/9/1 Rob Herring <robherring2@gmail.com>:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> Add empty version of l2x0_of_init for when CONFIG_CACHE_L2X0 is not selected.
>>
>> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
>
> Acked-by: Barry Song <21cnbao@gmail.com>
>
Thanks.
> it seems most people use
> "
> #ifdef CONFIG_CACHE_L2X0
> ...
> l2x0 related codes
> ...
> #endif
> "
> or
> "
> obj-$(CONFIG_CACHE_L2X0) += xxx-l2x0.o
> "
>
> to avoid l2x0 related codes compiled and linked into kernel.
>
> but this patch provides another option. it is not bad too.
>
The difference with existing platforms and l2x0_init is the ioremap or
static mapping and latency register setup for pl310 is outside the
function, so you still need an ifdef around all that. With l2x0_of_init,
all the setup is done inside the function, so having an empty version is
useful.
Rob
next prev parent reply other threads:[~2011-09-01 3:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 1:43 [PATCH v2 0/7] Initial Calxeda Highbank support Rob Herring
2011-09-01 1:44 ` [PATCH 1/7] ARM: l2x0: add empty l2x0_of_init Rob Herring
2011-09-01 3:36 ` Barry Song
2011-09-01 3:58 ` Rob Herring [this message]
2011-09-01 1:44 ` [PATCH v2 2/7] ARM: highbank: add devicetree source Rob Herring
2011-09-01 1:44 ` [PATCH v2 3/7] ARM: add Highbank core platform support Rob Herring
2011-09-01 1:44 ` [PATCH v2 4/7] MAINTAINERS: add Calxeda Highbank ARM platform Rob Herring
2011-09-01 1:44 ` [PATCH v2 5/7] ARM: highbank: add SMP support Rob Herring
2011-09-06 1:01 ` Shawn Guo
2011-10-05 16:00 ` Rob Herring
2011-10-07 12:40 ` Shawn Guo
2011-09-01 1:44 ` [PATCH v2 6/7] ARM: highbank: Add cpu hotplug support Rob Herring
2011-09-01 1:44 ` [PATCH v2 7/7] ARM: highbank: add suspend support Rob Herring
2011-09-01 12:22 ` Shawn Guo
2011-09-01 21:39 ` Rob Herring
2011-09-01 14:00 ` [PATCH v2 0/7] Initial Calxeda Highbank support Jamie Iles
2011-09-26 18:39 ` Rob Herring
2011-09-30 20:31 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5F02D5.6030508@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).