From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mach-integrator: fix VGA base regression
Date: Tue, 06 Sep 2011 08:31:59 -0500 [thread overview]
Message-ID: <4E6620CF.3020201@gmail.com> (raw)
In-Reply-To: <CAKnu2MrFsnZrq-Fzq3HpV8oAwa9Vi6fFqrSSB7+kq8r8V7ANQg@mail.gmail.com>
On 09/06/2011 12:25 AM, Linus Walleij wrote:
> 2011/9/5 Rob Herring <robherring2@gmail.com>:
>
>>>> Should the VGA memory really be accessed before PCI host is initialized?
>>>
>>> I don' know, I don't know one bit about how PCI works and should
>>> work, you tell me :-)
>>
>> I guess it's normal (from init/main.c):
>
> Ah. I've even seen that comment in main.c.
>
> SHall I go over the other changes in the same and check for
> potential problems?
>
Integrator and footbridge are the only platforms that would ever
actually work with VGA console because the others are all returning a
physical address rather than a virtual address. kirkwood, dove, mv78xx0,
and orion5x are all wrong. I'm not sure on shark. Seems to be a virtual
address, but it's not mapped.
So perhaps the correct fix is just to remove the initialization of
vga_base on all these platforms.
Rob
next prev parent reply other threads:[~2011-09-06 13:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-04 21:40 [PATCH] mach-integrator: fix VGA base regression Linus Walleij
2011-09-05 4:00 ` Rob Herring
2011-09-05 6:46 ` Linus Walleij
2011-09-05 15:30 ` Rob Herring
2011-09-06 5:25 ` Linus Walleij
2011-09-06 13:31 ` Rob Herring [this message]
2011-09-07 7:54 ` Linus Walleij
2011-09-05 12:35 ` Linus Walleij
2011-09-05 14:21 ` Arnd Bergmann
2011-09-20 20:43 ` Linus Walleij
2011-09-20 20:59 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6620CF.3020201@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox