* [PATCH] OMAP: omap_device: fix !CONFIG_SUSPEND case in _noirq handlers
@ 2011-09-01 18:12 Kevin Hilman
2011-09-01 18:22 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Kevin Hilman @ 2011-09-01 18:12 UTC (permalink / raw)
To: linux-arm-kernel
The suspend/resume _noirq handlers were #ifdef'd out in the
!CONFIG_SUSPEND case, but were still assigned to the dev_pm_ops
struct. Fix by defining them to NULL in the !CONFIG_SUSPEND case.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kevin Hilman <khilman@ti.com>
---
Applies to v3.1-rc4.
arch/arm/plat-omap/omap_device.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c
index 9a6a538..02609ee 100644
--- a/arch/arm/plat-omap/omap_device.c
+++ b/arch/arm/plat-omap/omap_device.c
@@ -615,6 +615,9 @@ static int _od_resume_noirq(struct device *dev)
return pm_generic_resume_noirq(dev);
}
+#else
+#define _od_suspend_noirq NULL
+#define _od_resume_noirq NULL
#endif
static struct dev_pm_domain omap_device_pm_domain = {
--
1.7.6
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] OMAP: omap_device: fix !CONFIG_SUSPEND case in _noirq handlers
2011-09-01 18:12 [PATCH] OMAP: omap_device: fix !CONFIG_SUSPEND case in _noirq handlers Kevin Hilman
@ 2011-09-01 18:22 ` Arnd Bergmann
2011-09-01 21:57 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2011-09-01 18:22 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 01 September 2011 11:12:02 Kevin Hilman wrote:
> The suspend/resume _noirq handlers were #ifdef'd out in the
> !CONFIG_SUSPEND case, but were still assigned to the dev_pm_ops
> struct. Fix by defining them to NULL in the !CONFIG_SUSPEND case.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Thansk for the fast response!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] OMAP: omap_device: fix !CONFIG_SUSPEND case in _noirq handlers
2011-09-01 18:22 ` Arnd Bergmann
@ 2011-09-01 21:57 ` Rafael J. Wysocki
2011-09-06 20:13 ` Kevin Hilman
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2011-09-01 21:57 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday, September 01, 2011, Arnd Bergmann wrote:
> On Thursday 01 September 2011 11:12:02 Kevin Hilman wrote:
> > The suspend/resume _noirq handlers were #ifdef'd out in the
> > !CONFIG_SUSPEND case, but were still assigned to the dev_pm_ops
> > struct. Fix by defining them to NULL in the !CONFIG_SUSPEND case.
> >
> > Reported-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Kevin Hilman <khilman@ti.com>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Thansk for the fast response!
I'll apply the patch when kernel.org is back in order.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] OMAP: omap_device: fix !CONFIG_SUSPEND case in _noirq handlers
2011-09-01 21:57 ` Rafael J. Wysocki
@ 2011-09-06 20:13 ` Kevin Hilman
2011-09-06 20:20 ` Kevin Hilman
0 siblings, 1 reply; 6+ messages in thread
From: Kevin Hilman @ 2011-09-06 20:13 UTC (permalink / raw)
To: linux-arm-kernel
On 09/01/2011 02:57 PM, Rafael J. Wysocki wrote:
> On Thursday, September 01, 2011, Arnd Bergmann wrote:
>> On Thursday 01 September 2011 11:12:02 Kevin Hilman wrote:
>>> The suspend/resume _noirq handlers were #ifdef'd out in the
>>> !CONFIG_SUSPEND case, but were still assigned to the dev_pm_ops
>>> struct. Fix by defining them to NULL in the !CONFIG_SUSPEND case.
>>>
>>> Reported-by: Arnd Bergmann<arnd@arndb.de>
>>> Signed-off-by: Kevin Hilman<khilman@ti.com>
>>
>> Acked-by: Arnd Bergmann<arnd@arndb.de>
>>
>> Thansk for the fast response!
>
> I'll apply the patch when kernel.org is back in order.
>
Tony,
I spoke w/Rafael and due to hera being down and Rafael traveling to LPC
he wont be able to queue this for v3.1. Can you queue up this fix?
This needs to go in to v3.1-rc.
Thanks,
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] OMAP: omap_device: fix !CONFIG_SUSPEND case in _noirq handlers
2011-09-06 20:13 ` Kevin Hilman
@ 2011-09-06 20:20 ` Kevin Hilman
2011-09-12 17:44 ` Kevin Hilman
0 siblings, 1 reply; 6+ messages in thread
From: Kevin Hilman @ 2011-09-06 20:20 UTC (permalink / raw)
To: linux-arm-kernel
On 09/06/2011 01:13 PM, Kevin Hilman wrote:
> On 09/01/2011 02:57 PM, Rafael J. Wysocki wrote:
>> On Thursday, September 01, 2011, Arnd Bergmann wrote:
>>> On Thursday 01 September 2011 11:12:02 Kevin Hilman wrote:
>>>> The suspend/resume _noirq handlers were #ifdef'd out in the
>>>> !CONFIG_SUSPEND case, but were still assigned to the dev_pm_ops
>>>> struct. Fix by defining them to NULL in the !CONFIG_SUSPEND case.
>>>>
>>>> Reported-by: Arnd Bergmann<arnd@arndb.de>
>>>> Signed-off-by: Kevin Hilman<khilman@ti.com>
>>>
>>> Acked-by: Arnd Bergmann<arnd@arndb.de>
>>>
>>> Thansk for the fast response!
>>
>> I'll apply the patch when kernel.org is back in order.
>>
>
> Tony,
>
> I spoke w/Rafael and due to hera being down and Rafael traveling to LPC
> he wont be able to queue this for v3.1. Can you queue up this fix? This
> needs to go in to v3.1-rc.
For convenience, this patch is in a branch in my backup gitorious repo
with Arnd's ack added:
git://gitorious.org/khilman/linux-omap-pm.git for_3.1/pm-fixes-2
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] OMAP: omap_device: fix !CONFIG_SUSPEND case in _noirq handlers
2011-09-06 20:20 ` Kevin Hilman
@ 2011-09-12 17:44 ` Kevin Hilman
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2011-09-12 17:44 UTC (permalink / raw)
To: linux-arm-kernel
Arnd,
On 09/06/2011 01:20 PM, Kevin Hilman wrote:
> On 09/06/2011 01:13 PM, Kevin Hilman wrote:
>> On 09/01/2011 02:57 PM, Rafael J. Wysocki wrote:
>>> On Thursday, September 01, 2011, Arnd Bergmann wrote:
>>>> On Thursday 01 September 2011 11:12:02 Kevin Hilman wrote:
>>>>> The suspend/resume _noirq handlers were #ifdef'd out in the
>>>>> !CONFIG_SUSPEND case, but were still assigned to the dev_pm_ops
>>>>> struct. Fix by defining them to NULL in the !CONFIG_SUSPEND case.
>>>>>
>>>>> Reported-by: Arnd Bergmann<arnd@arndb.de>
>>>>> Signed-off-by: Kevin Hilman<khilman@ti.com>
>>>>
>>>> Acked-by: Arnd Bergmann<arnd@arndb.de>
>>>>
>>>> Thansk for the fast response!
>>>
>>> I'll apply the patch when kernel.org is back in order.
>>>
>>
>> Tony,
>>
>> I spoke w/Rafael and due to hera being down and Rafael traveling to LPC
>> he wont be able to queue this for v3.1. Can you queue up this fix? This
>> needs to go in to v3.1-rc.
>
> For convenience, this patch is in a branch in my backup gitorious repo
> with Arnd's ack added:
>
> git://gitorious.org/khilman/linux-omap-pm.git for_3.1/pm-fixes-2
>
Can you pick this up for v3.1-rc also?
Thanks,
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-09-12 17:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-01 18:12 [PATCH] OMAP: omap_device: fix !CONFIG_SUSPEND case in _noirq handlers Kevin Hilman
2011-09-01 18:22 ` Arnd Bergmann
2011-09-01 21:57 ` Rafael J. Wysocki
2011-09-06 20:13 ` Kevin Hilman
2011-09-06 20:20 ` Kevin Hilman
2011-09-12 17:44 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).