From mboxrd@z Thu Jan  1 00:00:00 1970
From: sboyd@codeaurora.org (Stephen Boyd)
Date: Tue, 13 Sep 2011 00:01:17 -0700
Subject: [PATCH v3 1/2] i2c: s3c2410: Keep a copy of platform data and
	use it
In-Reply-To: <1315887365-30532-2-git-send-email-thomas.abraham@linaro.org>
References: <1315887365-30532-1-git-send-email-thomas.abraham@linaro.org>
	<1315887365-30532-2-git-send-email-thomas.abraham@linaro.org>
Message-ID: <4E6EFFBD.6050609@codeaurora.org>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 9/12/2011 9:16 PM, Thomas Abraham wrote:
> @@ -809,6 +810,15 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  	}
>  
> +	i2c->pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
> +	if (!i2c->pdata) {
> +		ret = -ENOMEM;
> +		goto err_noclk;
> +	}
> +
> +	if (pdata)
> +		memcpy(i2c->pdata, pdata, sizeof(*pdata));
> +

Is there a devm_kmemdup()? If not, maybe it would be a good idea to add it.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.