From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: CSR: call l2x0_of_init to init L2 cache of SiRFprimaII
Date: Tue, 13 Sep 2011 13:01:57 -0500 [thread overview]
Message-ID: <4E6F9A95.1010109@gmail.com> (raw)
In-Reply-To: <201109131835.14230.arnd@arndb.de>
On 09/13/2011 11:35 AM, Arnd Bergmann wrote:
> On Tuesday 13 September 2011, Rob Herring wrote:
>> I have it in init_irq as I need the outer flush to work for SMP init.
>> init_machine may be okay as well, but as early as possible is probably
>> best. It depends if you are turning on the L2 or it is already on when
>> you boot.
>>
>> You could also just check your machine compatible string in this
>> function, but calling it from a machine specific function is a cleaner
>> solution.
>
> I would suggest checking the specific "compatible" string of the l2x0
> device node, and making sure that you have something specific to
> prima2 in it.
>
> That would easily let us combine this function with the respective
> l2x0 init code for other dt based platforms later, by checking
> multiple compatible values.
>
The function does that, but you have a problem when multiple platforms
have a "arm,pl310-cache" string. Or are you saying we need to have
"csr,prima2-pl310-cache" and strings for every platform out there with a
pl310?
Rob
next prev parent reply other threads:[~2011-09-13 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 9:10 [PATCH] ARM: CSR: call l2x0_of_init to init L2 cache of SiRFprimaII Barry Song
2011-09-13 13:59 ` Rob Herring
2011-09-13 14:43 ` Barry Song
2011-09-13 15:33 ` Rob Herring
2011-09-13 16:35 ` Arnd Bergmann
2011-09-13 18:01 ` Rob Herring [this message]
2011-09-14 6:41 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6F9A95.1010109@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).