linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] OMAP: PM: omap_device: add omap_hwmod_name_get_odev
Date: Mon, 26 Sep 2011 11:18:56 -0700	[thread overview]
Message-ID: <4E80C210.8090200@deeprootsystems.com> (raw)
In-Reply-To: <1314026347-21623-2-git-send-email-b-cousson@ti.com>

On 08/22/2011 08:19 AM, Benoit Cousson wrote:
> From: Nishanth Menon<nm@ti.com>
>
> An API which translates a standard hwmod name to corresponding
> omap_device is useful for drivers when they need to look up the
> device associated with a hwmod name to map back into the device
> structure pointers. These ideally should be used by drivers in
> mach directory. Using a generic hwmod name like "gpu" instead of
> the actual device name which could change in the future, allows
> us to:
> a) Could in effect help replace apis such as omap2_get_mpuss_device,
> omap2_get_iva_device, omap2_get_l3_device, omap4_get_dsp_device,
> etc..
> b) Scale to more devices rather than be restricted to named functions
> c) Simplify driver's platform_data from passing additional fields
> all doing the same thing with different function pointer names
> just for accessing a different device name.
>
> Signed-off-by: Nishanth Menon<nm@ti.com>
> [b-cousson at ti.com: rebased on top of Kevin's changes]
> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
> ---
>   arch/arm/plat-omap/include/plat/omap_device.h |    1 +
>   arch/arm/plat-omap/omap_device.c              |   32 +++++++++++++++++++++++++
>   2 files changed, 33 insertions(+), 0 deletions(-)

One other comment on the API here.

This is an omap_hwmod_* API being added to omap_device.h.

Seems like the function name should be something more like:
omap_device_get_by_name()  (or _get_by_hwmod_name() or something.)

Kevin

  parent reply	other threads:[~2011-09-26 18:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 15:19 [PATCH 0/7] OMAP: omap_device cleanup before device-tree integration Benoit Cousson
2011-08-22 15:19 ` [PATCH 1/7] OMAP: PM: omap_device: add omap_hwmod_name_get_odev Benoit Cousson
2011-08-31 22:20   ` Kevin Hilman
2011-09-01 11:48     ` Cousson, Benoit
2011-09-01 20:44       ` Menon, Nishanth
2011-09-26 18:18   ` Kevin Hilman [this message]
2011-08-22 15:19 ` [PATCH 2/7] OMAP: PM: omap_device: add few quick access functions Benoit Cousson
2011-08-31 22:23   ` Kevin Hilman
2011-09-01 11:55     ` Cousson, Benoit
2011-09-01 14:55       ` Kevin Hilman
2011-09-02 12:39     ` Cousson, Benoit
2011-08-22 15:19 ` [PATCH 3/7] OMAP3: beagle-board: Use the omap_hwmod_name_get_dev API Benoit Cousson
2011-08-31 22:24   ` Kevin Hilman
2011-08-22 15:19 ` [PATCH 4/7] OMAP2+: pm: Use hwmod name instead of dev pointer Benoit Cousson
2011-08-31 22:24   ` Kevin Hilman
2011-08-22 15:19 ` [PATCH 5/7] OMAP2+: pm: Remove static devices variable for mpu, dsp, iva and l3 PM Benoit Cousson
2011-08-31 22:25   ` Kevin Hilman
2011-08-22 15:19 ` [PATCH 6/7] OMAP: omap_device: Create a default omap_device_pm_latency Benoit Cousson
2011-08-31 22:30   ` Kevin Hilman
2011-08-22 15:19 ` [PATCH 7/7] OMAP2+: devices: Remove all omap_device_pm_latency structures Benoit Cousson
2011-08-31 22:31   ` Kevin Hilman
2011-09-01 11:59     ` Cousson, Benoit
2011-09-01 16:28 ` [PATCH 0/7] OMAP: omap_device cleanup before device-tree integration Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E80C210.8090200@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).