From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: Git pull request: mach/vmalloc.h removal, and ioremap optimizations
Date: Thu, 29 Sep 2011 15:26:39 -0500 [thread overview]
Message-ID: <4E84D47F.7030007@gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1109291439110.9106@xanadu.home>
On 09/29/2011 01:42 PM, Nicolas Pitre wrote:
> On Thu, 29 Sep 2011, Rob Herring wrote:
>
>> On 09/29/2011 12:37 PM, Russell King - ARM Linux wrote:
>>> My guess would be:
>>>
>>> }, {
>>> .virtual = IO_ADDRESS(VERSATILE_SCTL_BASE),
>>> .pfn = __phys_to_pfn(VERSATILE_SCTL_BASE),
>>> .length = SZ_4K * 9,
>>> .type = MT_DEVICE
>>> },
>>> #ifdef CONFIG_MACH_VERSATILE_AB
>>> {
>>> .virtual = IO_ADDRESS(VERSATILE_GPIO0_BASE),
>>> .pfn = __phys_to_pfn(VERSATILE_GPIO0_BASE),
>>> .length = SZ_4K,
>>> .type = MT_DEVICE
>>>
>>> #define VERSATILE_SCTL_BASE 0x101E0000 /* System controller */
>>> #define VERSATILE_GPIO0_BASE 0x101E4000 /* GPIO port 0 */
>>>
>>> I don't see why GPIO0 is explicitly listed here.
>>
>> It works for PB and AB with that removed. Here's a patch:
> [...]
>
> Thanks for testing and the patch. I've inserted it in my patch series
> and pushed the result out.
So it was really Realview PBX I wanted to test my GIC changes on. Well,
turns out it's got a similar problem, too.
However, the fix for it should perhaps be a bit different. The problem
is that the virtual address of REALVIEW_PBX_TILE_GIC_CPU_BASE is not
aligned. Then 0x100 + 4KB length overlaps into the DIST_BASE. So do we
fix it in the platform or should the core code mask out the lower bits
of the virt addr before doing any size calculations?
Rob
next prev parent reply other threads:[~2011-09-29 20:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 13:32 Git pull request: mach/vmalloc.h removal, and ioremap optimizations Nicolas Pitre
2011-09-29 15:59 ` Rob Herring
2011-09-29 17:19 ` Nicolas Pitre
2011-09-29 17:37 ` Russell King - ARM Linux
2011-09-29 18:25 ` Rob Herring
2011-09-29 18:42 ` Nicolas Pitre
2011-09-29 20:26 ` Rob Herring [this message]
2011-09-29 20:47 ` Nicolas Pitre
2011-09-29 21:19 ` Rob Herring
2011-09-29 21:22 ` [PATCH] ARM: realview: fix map_desc alignment Rob Herring
2011-09-29 23:57 ` Git pull request: mach/vmalloc.h removal, and ioremap optimizations Nicolas Pitre
2011-09-30 0:46 ` [PATCH] ARM: realview-eb11mp: fix map_desc alignment Rob Herring
2011-09-30 1:34 ` Nicolas Pitre
2011-10-04 18:49 ` Git pull request: mach/vmalloc.h removal, and ioremap optimizations Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E84D47F.7030007@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).