From: jason77.wang@gmail.com (Hui Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mx5: modify pm and idle
Date: Sat, 8 Oct 2011 09:33:56 +0800 [thread overview]
Message-ID: <4E8FA884.5010308@gmail.com> (raw)
In-Reply-To: <20111003052458.GA21563@S2100-06.ap.freescale.net>
Shawn Guo wrote:
> On Fri, Sep 30, 2011 at 02:37:22PM +0800, Hui Wang wrote:
>
>> Two problems exist in the current i.MX5 pm suspend/resume and idle
>> functions. The first is the current i.MX5 suspend routine will call
>>
<snip>
>> MPGC1_SRPGCR);
>> }
>> }
>> +
>> +void mx5_arch_idle(void)
>> +{
>> + if (gpc_dvfs_clk == NULL)
>> + gpc_dvfs_clk = clk_get(NULL, "gpc_dvfs");
>> +
>> + /* gpc clock is needed for SRPG */
>> + clk_enable(gpc_dvfs_clk);
>> + mx5_cpu_lp_set(WAIT_UNCLOCKED_POWER_OFF);
>> + if (tzic_enable_wake() != 0)
>> + goto exit;
>> + cpu_do_idle();
>> +exit:
>> + clk_disable(gpc_dvfs_clk);
>>
>
> Bad indentation on entire function block (should be 1 tab rather than 2)
>
> Regards,
> Shawn
>
>
Got it. I will fix it in the V2.
>> +}
>> diff --git a/arch/arm/plat-mxc/include/mach/mxc.h b/arch/arm/plat-mxc/include/mach/mxc.h
>> index 0987923..c4d324a 100644
>> --- a/arch/arm/plat-mxc/include/mach/mxc.h
>> +++ b/arch/arm/plat-mxc/include/mach/mxc.h
>> @@ -182,7 +182,7 @@ struct cpu_op {
>> u32 cpu_rate;
>> };
>>
>>
next prev parent reply other threads:[~2011-10-08 1:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 6:37 [PATCH] mx5: modify pm and idle Hui Wang
2011-10-03 5:24 ` Shawn Guo
2011-10-08 1:33 ` Hui Wang [this message]
2011-10-04 7:43 ` Sascha Hauer
2011-10-08 1:34 ` Hui Wang
2011-10-08 2:06 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8FA884.5010308@gmail.com \
--to=jason77.wang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).