linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ulf.hansson@stericsson.com (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: mmci: Do not release spinlock in request_end
Date: Fri, 14 Oct 2011 09:51:44 +0200	[thread overview]
Message-ID: <4E97EA10.6040800@stericsson.com> (raw)
In-Reply-To: <20111014074224.GQ21648@n2100.arm.linux.org.uk>

Russell King - ARM Linux wrote:
> On Fri, Oct 14, 2011 at 09:37:51AM +0200, Ulf Hansson wrote:
>> Jon Medhurst (Tixy) wrote:
>>> On Thu, 2011-10-13 at 15:29 +0100, Russell King - ARM Linux wrote:
>>>> On Tue, Oct 11, 2011 at 04:06:41PM +0200, Ulf Hansson wrote:
>>>>> The patch "mmc: core: move ->request() call from atomic context",
>>>>> is the reason to why this change is possible. This simplifies the
>>>>> error handling code execution path quite a lot and potentially also
>>>>> fixes some error handling hang problems.
>>>>>
>>>>> Signed-off-by: Ulf Hansson <ulf.hansson@stericsson.com>
>>>> This doesn't look right:
>>>>
>>>> void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq)
>>>> {
>>>>         if (err && cmd->retries) {
>>>>                 host->ops->request(host, mrq);
>>>>
>> This is NOT how it looks at mmc-next. You need to test with Adrian  
>> Hunters patch which the commit refers two.
> 
> In that case, how can I take the patch to mmci if it depends on something
> in another tree?
> 

I don't know. But how do you update your tree from next normally? I 
believe the problem is more related to that the mmc-next tree is now on 
a temporary git. If you do not update your tree how shall we be able to 
continue with integration of new patches that depends on mmc patches 
from "next"?

BR
Uffe

  reply	other threads:[~2011-10-14  7:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-11 14:06 [PATCH] mmc: mmci: Do not release spinlock in request_end Ulf Hansson
2011-10-12  9:41 ` Linus Walleij
2011-10-12 10:33   ` Adrian Hunter
2011-10-13 14:29 ` Russell King - ARM Linux
2011-10-13 15:59   ` Jon Medhurst (Tixy)
2011-10-14  7:37     ` Ulf Hansson
2011-10-14  7:42       ` Russell King - ARM Linux
2011-10-14  7:51         ` Ulf Hansson [this message]
2011-10-14  8:03           ` Russell King - ARM Linux
2011-10-14  8:22             ` Ulf Hansson
2011-10-16 20:34               ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E97EA10.6040800@stericsson.com \
    --to=ulf.hansson@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).