From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: linux-next failure on tegra due to conflicts between PPI and irq domain patches and irq.h->module.h include removal
Date: Tue, 25 Oct 2011 17:00:17 -0500 [thread overview]
Message-ID: <4EA73171.5020207@gmail.com> (raw)
In-Reply-To: <CAOesGMhqRg29tq5Cw03UQMzGs_6nc3YA9UE6Cvps_0q7h5OeZw@mail.gmail.com>
Olof,
On 10/25/2011 04:48 PM, Olof Johansson wrote:
> Hi,
>
> Looks like Marc added new references to irq_start in his PPI patch,
> and Rob removed it in parallel. Also, irq_offset is no longer
> available. Looks like you need to respin your patch, Marc.
>
> arch/arm/common/gic.c: In function 'gic_dist_init':
> arch/arm/common/gic.c:290: error: 'irq_start' undeclared (first use in
> this function)
> arch/arm/common/gic.c:290: error: (Each undeclared identifier is
> reported only once
> arch/arm/common/gic.c:290: error: for each function it appears in.)
> arch/arm/common/gic.c:296: error: 'struct gic_chip_data' has no member
> named 'irq_offset'
I fixed this and sent a pull request yesterday to Arnd.
> The second error is because of the change from Paul that removes
> module.h from irq.h:
>
> arch/arm/common/gic.c: In function 'gic_init':
> arch/arm/common/gic.c:620: error: 'THIS_MODULE' undeclared (first use
> in this function)
>
> Looks odd that I should need to include module.h on my own just to use
> irq defines. Paul?
>
THIS_MODULE is needed by irq.h itself in irq_alloc_descs, so it probably
needs to be added back.
Rob
next prev parent reply other threads:[~2011-10-25 22:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 21:48 linux-next failure on tegra due to conflicts between PPI and irq domain patches and irq.h->module.h include removal Olof Johansson
2011-10-25 22:00 ` Rob Herring [this message]
2011-10-25 22:01 ` Olof Johansson
2011-10-26 14:27 ` Paul Gortmaker
2011-10-26 14:35 ` Olof Johansson
2011-10-26 14:58 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA73171.5020207@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).