* [PATCH] ARM: mark empty gpio.h files empty
@ 2011-10-28 20:19 Linus Walleij
2011-10-28 20:36 ` Jeff Garzik
2011-10-29 11:06 ` Grant Likely
0 siblings, 2 replies; 4+ messages in thread
From: Linus Walleij @ 2011-10-28 20:19 UTC (permalink / raw)
To: linux-arm-kernel
It is generally a better idea to make intentionally empty files
contain the human-readable /* empty */ comment, also it makes
the files play nice with "make distclean".
Reported-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/mach-lpc32xx/include/mach/gpio.h | 1 +
arch/arm/mach-tegra/include/mach/gpio.h | 1 +
arch/arm/mach-u300/include/mach/gpio.h | 1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-lpc32xx/include/mach/gpio.h b/arch/arm/mach-lpc32xx/include/mach/gpio.h
index e69de29..40a8c17 100644
--- a/arch/arm/mach-lpc32xx/include/mach/gpio.h
+++ b/arch/arm/mach-lpc32xx/include/mach/gpio.h
@@ -0,0 +1 @@
+/* empty */
diff --git a/arch/arm/mach-tegra/include/mach/gpio.h b/arch/arm/mach-tegra/include/mach/gpio.h
index e69de29..40a8c17 100644
--- a/arch/arm/mach-tegra/include/mach/gpio.h
+++ b/arch/arm/mach-tegra/include/mach/gpio.h
@@ -0,0 +1 @@
+/* empty */
diff --git a/arch/arm/mach-u300/include/mach/gpio.h b/arch/arm/mach-u300/include/mach/gpio.h
index e69de29..40a8c17 100644
--- a/arch/arm/mach-u300/include/mach/gpio.h
+++ b/arch/arm/mach-u300/include/mach/gpio.h
@@ -0,0 +1 @@
+/* empty */
--
1.7.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: mark empty gpio.h files empty
2011-10-28 20:19 [PATCH] ARM: mark empty gpio.h files empty Linus Walleij
@ 2011-10-28 20:36 ` Jeff Garzik
2011-10-29 11:06 ` Grant Likely
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2011-10-28 20:36 UTC (permalink / raw)
To: linux-arm-kernel
On 10/28/2011 04:19 PM, Linus Walleij wrote:
> It is generally a better idea to make intentionally empty files
> contain the human-readable /* empty */ comment, also it makes
> the files play nice with "make distclean".
>
> Reported-by: Jeff Garzik<jeff@garzik.org>
> Signed-off-by: Linus Walleij<linus.walleij@linaro.org>
Thanks!
Acked-by: Jeff Garzik <jgarzik@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: mark empty gpio.h files empty
2011-10-28 20:19 [PATCH] ARM: mark empty gpio.h files empty Linus Walleij
2011-10-28 20:36 ` Jeff Garzik
@ 2011-10-29 11:06 ` Grant Likely
2011-10-31 15:50 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Grant Likely @ 2011-10-29 11:06 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Oct 28, 2011 at 10:19:02PM +0200, Linus Walleij wrote:
> It is generally a better idea to make intentionally empty files
> contain the human-readable /* empty */ comment, also it makes
> the files play nice with "make distclean".
>
> Reported-by: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thanks.
g.
> ---
> arch/arm/mach-lpc32xx/include/mach/gpio.h | 1 +
> arch/arm/mach-tegra/include/mach/gpio.h | 1 +
> arch/arm/mach-u300/include/mach/gpio.h | 1 +
> 3 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-lpc32xx/include/mach/gpio.h b/arch/arm/mach-lpc32xx/include/mach/gpio.h
> index e69de29..40a8c17 100644
> --- a/arch/arm/mach-lpc32xx/include/mach/gpio.h
> +++ b/arch/arm/mach-lpc32xx/include/mach/gpio.h
> @@ -0,0 +1 @@
> +/* empty */
> diff --git a/arch/arm/mach-tegra/include/mach/gpio.h b/arch/arm/mach-tegra/include/mach/gpio.h
> index e69de29..40a8c17 100644
> --- a/arch/arm/mach-tegra/include/mach/gpio.h
> +++ b/arch/arm/mach-tegra/include/mach/gpio.h
> @@ -0,0 +1 @@
> +/* empty */
> diff --git a/arch/arm/mach-u300/include/mach/gpio.h b/arch/arm/mach-u300/include/mach/gpio.h
> index e69de29..40a8c17 100644
> --- a/arch/arm/mach-u300/include/mach/gpio.h
> +++ b/arch/arm/mach-u300/include/mach/gpio.h
> @@ -0,0 +1 @@
> +/* empty */
> --
> 1.7.3.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: mark empty gpio.h files empty
2011-10-29 11:06 ` Grant Likely
@ 2011-10-31 15:50 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2011-10-31 15:50 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Oct 29, 2011 at 1:06 PM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Fri, Oct 28, 2011 at 10:19:02PM +0200, Linus Walleij wrote:
>> It is generally a better idea to make intentionally empty files
>> contain the human-readable /* empty */ comment, also it makes
>> the files play nice with "make distclean".
>>
>> Reported-by: Jeff Garzik <jeff@garzik.org>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Applied, thanks.
Hm I put that into Russell's patch tracker since it was mainly
touching arch/arm/*
and I think he applied it too.
Well whatever, git will cope.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-31 15:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-28 20:19 [PATCH] ARM: mark empty gpio.h files empty Linus Walleij
2011-10-28 20:36 ` Jeff Garzik
2011-10-29 11:06 ` Grant Likely
2011-10-31 15:50 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).