From: rmallon@gmail.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: restart: remove argument to setup_mm_for_reboot()
Date: Wed, 02 Nov 2011 09:27:03 +1100 [thread overview]
Message-ID: <4EB07237.1090001@gmail.com> (raw)
In-Reply-To: <E1RLGt2-0005IN-A0@rmk-PC.arm.linux.org.uk>
On 02/11/11 03:08, Russell King - ARM Linux wrote:
> setup_mm_for_reboot() doesn't make use of its argument, so remove it.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> arch/arm/kernel/machine_kexec.c | 4 ++--
> arch/arm/kernel/process.c | 4 ++--
> arch/arm/mm/idmap.c | 2 +-
> arch/arm/mm/nommu.c | 2 +-
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
> index c1b4463..6fcdfc4 100644
> --- a/arch/arm/kernel/machine_kexec.c
> +++ b/arch/arm/kernel/machine_kexec.c
> @@ -16,7 +16,7 @@
> extern const unsigned char relocate_new_kernel[];
> extern const unsigned int relocate_new_kernel_size;
>
> -extern void setup_mm_for_reboot(char mode);
> +extern void setup_mm_for_reboot(void);
>
> extern unsigned long kexec_start_address;
> extern unsigned long kexec_indirection_page;
> @@ -114,7 +114,7 @@ void machine_kexec(struct kimage *image)
> kexec_reinit();
> local_irq_disable();
> local_fiq_disable();
> - setup_mm_for_reboot(0); /* mode is not used, so just pass 0*/
> + setup_mm_for_reboot(); /* mode is not used, so just pass 0*/
The comment should get removed now also.
~Ryan
next prev parent reply other threads:[~2011-11-01 22:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 16:07 [RFC 0/5] restart cleanups Russell King - ARM Linux
2011-11-01 16:08 ` [PATCH 1/5] ARM: restart: remove argument to setup_mm_for_reboot() Russell King - ARM Linux
2011-11-01 22:27 ` Ryan Mallon [this message]
2011-11-02 14:48 ` Russell King - ARM Linux
2011-11-01 16:08 ` [PATCH 2/5] ARM: restart: get rid of needless at91_arch_reset additional indirection Russell King - ARM Linux
2011-11-01 16:09 ` [PATCH 3/5] ARM: restart: remove local_irq_disable() from within arch_reset() Russell King - ARM Linux
2011-11-01 16:36 ` H Hartley Sweeten
2011-11-01 17:56 ` Russell King - ARM Linux
2011-11-01 16:09 ` [PATCH 4/5] ARM: restart: turn reboot setup code into a library function Russell King - ARM Linux
2011-11-01 16:09 ` [PATCH 5/5] ARM: restart: only perform setup for restart when soft-restarting Russell King - ARM Linux
2011-11-02 12:12 ` Will Deacon
2011-11-02 12:37 ` Russell King - ARM Linux
2011-11-02 13:11 ` Will Deacon
2011-11-01 16:38 ` [RFC 0/5] restart cleanups Russell King - ARM Linux
2011-11-03 9:12 ` Russell King - ARM Linux
2011-11-03 9:24 ` Kukjin Kim
2011-11-03 9:57 ` Russell King - ARM Linux
2011-11-01 17:02 ` Russell King - ARM Linux
2011-11-02 13:49 ` Richard Purdie
2011-11-02 14:49 ` Russell King - ARM Linux
2011-11-04 13:58 ` Andrea Adami
2011-11-04 14:01 ` Russell King - ARM Linux
2011-11-04 14:22 ` Andrea Adami
2011-11-01 19:23 ` Will Deacon
2011-11-01 19:41 ` Russell King - ARM Linux
2011-11-01 21:19 ` Will Deacon
2011-11-01 23:09 ` Russell King - ARM Linux
2011-11-02 21:33 ` Robert Jarzmik
2011-11-02 23:31 ` Russell King - ARM Linux
2011-11-02 13:35 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB07237.1090001@gmail.com \
--to=rmallon@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).