linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCHv2] ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size
@ 2011-10-13  6:50 Thomas Weber
  2011-10-13  8:38 ` Russell King - ARM Linux
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Weber @ 2011-10-13  6:50 UTC (permalink / raw)
  To: linux-arm-kernel

Use $(CROSS_COMPILE)size to determine the bss size
from vmlinux.

The problem is introduced in:

commit 5ffb04f6690d71fab241b3562ebf52b893ac4ff1
ARM: zImage: make sure appended DTB doesn't get
overwritten by kernel .bss

This fixes following error message:

size: arch/arm/boot/compressed/../../../../vmlinux:
File format is ambiguous

size: Matching formats:
elf32-littlearm
elf32-littlearm-symbian
elf32-littlearm-vxworks

Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Thomas Weber <weber@corscience.de>
---
v2: 
 - Fixed commit hash and rebased to rmk/devel-stable branch.
 - Added received Acked-by

 arch/arm/boot/compressed/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
index e4f32a8..3103632 100644
--- a/arch/arm/boot/compressed/Makefile
+++ b/arch/arm/boot/compressed/Makefile
@@ -126,7 +126,7 @@ ccflags-y := -fpic -fno-builtin -I$(obj)
 asflags-y := -Wa,-march=all
 
 # Supply kernel BSS size to the decompressor via a linker symbol.
-KBSS_SZ = $(shell size $(obj)/../../../../vmlinux | awk 'END{print $$3}')
+KBSS_SZ = $(shell $(CROSS_COMPILE)size $(obj)/../../../../vmlinux | awk 'END{print $$3}')
 LDFLAGS_vmlinux = --defsym _kernel_bss_size=$(KBSS_SZ)
 # Supply ZRELADDR to the decompressor via a linker symbol.
 ifneq ($(CONFIG_AUTO_ZRELADDR),y)
-- 
1.7.7

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCHv2] ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size
  2011-10-13  6:50 [PATCHv2] ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size Thomas Weber
@ 2011-10-13  8:38 ` Russell King - ARM Linux
  2011-10-13 18:56   ` Nicolas Pitre
  0 siblings, 1 reply; 4+ messages in thread
From: Russell King - ARM Linux @ 2011-10-13  8:38 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Oct 13, 2011 at 08:50:22AM +0200, Thomas Weber wrote:
> Use $(CROSS_COMPILE)size to determine the bss size
> from vmlinux.
> 
> The problem is introduced in:
> 
> commit 5ffb04f6690d71fab241b3562ebf52b893ac4ff1
> ARM: zImage: make sure appended DTB doesn't get
> overwritten by kernel .bss
> 
> This fixes following error message:
> 
> size: arch/arm/boot/compressed/../../../../vmlinux:
> File format is ambiguous
> 
> size: Matching formats:
> elf32-littlearm
> elf32-littlearm-symbian
> elf32-littlearm-vxworks
> 
> Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
> Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Thomas Weber <weber@corscience.de>

This is going to totally break my ability to build any kernels at the
moment - for some reason I don't have an arm-linux-size with all the
other bits of binutils, so I've been relying on the x86 version so far.
I'll add it to the list of things to look at...

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCHv2] ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size
  2011-10-13  8:38 ` Russell King - ARM Linux
@ 2011-10-13 18:56   ` Nicolas Pitre
  2011-11-02 12:35     ` Thomas Weber
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Pitre @ 2011-10-13 18:56 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, 13 Oct 2011, Russell King - ARM Linux wrote:

> On Thu, Oct 13, 2011 at 08:50:22AM +0200, Thomas Weber wrote:
> > Use $(CROSS_COMPILE)size to determine the bss size
> > from vmlinux.
> > 
> > The problem is introduced in:
> > 
> > commit 5ffb04f6690d71fab241b3562ebf52b893ac4ff1
> > ARM: zImage: make sure appended DTB doesn't get
> > overwritten by kernel .bss
> > 
> > This fixes following error message:
> > 
> > size: arch/arm/boot/compressed/../../../../vmlinux:
> > File format is ambiguous
> > 
> > size: Matching formats:
> > elf32-littlearm
> > elf32-littlearm-symbian
> > elf32-littlearm-vxworks
> > 
> > Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
> > Acked-by: Tony Lindgren <tony@atomide.com>
> > Signed-off-by: Thomas Weber <weber@corscience.de>
> 
> This is going to totally break my ability to build any kernels at the
> moment - for some reason I don't have an arm-linux-size with all the
> other bits of binutils, so I've been relying on the x86 version so far.

Naive suggestion: ln -s /usr/bin/size arm-linux-size


Nicolas

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCHv2] ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size
  2011-10-13 18:56   ` Nicolas Pitre
@ 2011-11-02 12:35     ` Thomas Weber
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Weber @ 2011-11-02 12:35 UTC (permalink / raw)
  To: linux-arm-kernel

Am 13.10.2011 20:56, schrieb Nicolas Pitre:
> On Thu, 13 Oct 2011, Russell King - ARM Linux wrote:
>
>> On Thu, Oct 13, 2011 at 08:50:22AM +0200, Thomas Weber wrote:
>>> Use $(CROSS_COMPILE)size to determine the bss size
>>> from vmlinux.
>>>
>>> The problem is introduced in:
>>>
>>> commit 5ffb04f6690d71fab241b3562ebf52b893ac4ff1
>>> ARM: zImage: make sure appended DTB doesn't get
>>> overwritten by kernel .bss
>>>
>>> This fixes following error message:
>>>
>>> size: arch/arm/boot/compressed/../../../../vmlinux:
>>> File format is ambiguous
>>>
>>> size: Matching formats:
>>> elf32-littlearm
>>> elf32-littlearm-symbian
>>> elf32-littlearm-vxworks
>>>
>>> Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
>>> Acked-by: Tony Lindgren <tony@atomide.com>
>>> Signed-off-by: Thomas Weber <weber@corscience.de>
>> This is going to totally break my ability to build any kernels at the
>> moment - for some reason I don't have an arm-linux-size with all the
>> other bits of binutils, so I've been relying on the x86 version so far.
> Naive suggestion: ln -s /usr/bin/size arm-linux-size
>
>
> Nicolas
>
>
Hello Russell,

what is the status of this patch?

Thomas

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-11-02 12:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-13  6:50 [PATCHv2] ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size Thomas Weber
2011-10-13  8:38 ` Russell King - ARM Linux
2011-10-13 18:56   ` Nicolas Pitre
2011-11-02 12:35     ` Thomas Weber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).