From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] atmel/spi: fix missing probe
Date: Thu, 03 Nov 2011 18:50:31 +0100 [thread overview]
Message-ID: <4EB2D467.7050901@gmail.com> (raw)
In-Reply-To: <1320342082-18573-1-git-send-email-plagnioj@jcrosoft.com>
On 11/03/2011 06:41 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Commit 940ab889 "drivercore: Add helper macro for platform_driver boilerplate"
> converted this driver to use module_platform_driver, but due to the use
> of platform_driver_probe(), this resulted in the call to atmel_spi_probe being
> lost. Place the call to this function into the driver structure.
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD<plagnioj@jcrosoft.com>
> Cc: Greg Kroah-Hartman<gregkh@suse.de>
> Cc: Grant Likely<grant.likely@secretlab.ca>
> Cc: Russell King - ARM Linux<linux@arm.linux.org.uk>
> ---
> v3:
>
> update commit message
> drivers/spi/spi-atmel.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 79665e2..3cd4f49 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1072,6 +1072,7 @@ static struct platform_driver atmel_spi_driver = {
> },
> .suspend = atmel_spi_suspend,
> .resume = atmel_spi_resume,
> + .prove = atmel_spi_probe,
^^^^^
This is certainly a typo. Didn't you even compile-test this?
Daniel
next prev parent reply other threads:[~2011-11-03 17:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 17:41 [PATCH 1/2] atmel/spi: fix missing probe Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 17:41 ` [PATCH 2/2] atmel/spi: fix section missmatch Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 17:50 ` Daniel Mack [this message]
2011-11-03 17:56 ` [PATCH 1/2] atmel/spi: fix missing probe Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 17:57 ` [PATCH 1/2 v4] " Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 22:47 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB2D467.7050901@gmail.com \
--to=zonque@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).