From mboxrd@z Thu Jan 1 00:00:00 1970 From: zonque@gmail.com (Daniel Mack) Date: Thu, 03 Nov 2011 18:50:31 +0100 Subject: [PATCH 1/2] atmel/spi: fix missing probe In-Reply-To: <1320342082-18573-1-git-send-email-plagnioj@jcrosoft.com> References: <1320342082-18573-1-git-send-email-plagnioj@jcrosoft.com> Message-ID: <4EB2D467.7050901@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/03/2011 06:41 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > Commit 940ab889 "drivercore: Add helper macro for platform_driver boilerplate" > converted this driver to use module_platform_driver, but due to the use > of platform_driver_probe(), this resulted in the call to atmel_spi_probe being > lost. Place the call to this function into the driver structure. > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > Cc: Greg Kroah-Hartman > Cc: Grant Likely > Cc: Russell King - ARM Linux > --- > v3: > > update commit message > drivers/spi/spi-atmel.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 79665e2..3cd4f49 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -1072,6 +1072,7 @@ static struct platform_driver atmel_spi_driver = { > }, > .suspend = atmel_spi_suspend, > .resume = atmel_spi_resume, > + .prove = atmel_spi_probe, ^^^^^ This is certainly a typo. Didn't you even compile-test this? Daniel