From: dirk.behme@googlemail.com (Dirk Behme)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] distclean: Remove generated .dtb files
Date: Mon, 07 Nov 2011 07:25:19 +0100 [thread overview]
Message-ID: <4EB779CF.4040007@googlemail.com> (raw)
In-Reply-To: <CACxGe6vK24j=L_WQWf5eqmdKXf0gCD=waAbJj4eq9d63O8mbvA@mail.gmail.com>
On 06.11.2011 19:42, Grant Likely wrote:
> On Sun, Nov 6, 2011 at 11:38 AM, Grant Likely<grant.likely@secretlab.ca> wrote:
>> On Sat, Nov 05, 2011 at 07:19:15AM +0100, Dirk Behme wrote:
>>> The patch 'arm/dt: Add dtb make rule' adds support to
>>> create a .dtb file. But this is never removed afterwards.
>>> Remove the generated .dtb file if 'distclean' is called.
>>>
>>> Signed-off-by: Dirk Behme<dirk.behme@de.bosch.com>
>>> CC: Rob Herring<rob.herring@calxeda.com>
>>> CC: Shawn Guo<shawn.guo@freescale.com>
>>> CC: Jason Liu<jason.hui@linaro.org>
>>> CC: Grant Likely<grant.likely@secretlab.ca>
>>
>> Acked-by: Grant Likely<grant.likely@secretlab.ca>
>
> ... although why are only the .dtb files needed in the clean list?
> How are the other built files cleaned? 'make clean' does remove the
> other images, but I don't know what the mechanism is.
A lot of stuff is removed by the top level Makefile [1]. But as the
patch "arm/dt: Add dtb make rule" adds the .dtb generation to
arch/arm/boot/Makefile, we thought it would be a good place to add the
removal of that file there, too.
Hmm, not sure if this answers your question, though ;)
Best regards
Dirk
[1]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=Makefile;h=ed25c5b35470dc2035f8b024994fa6cb7cecaca6;hb=HEAD#l1188
>>
>>> ---
>>> arch/arm/boot/Makefile | 2 ++
>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
>>> index 1cd9b0a..08f0d35 100644
>>> --- a/arch/arm/boot/Makefile
>>> +++ b/arch/arm/boot/Makefile
>>> @@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts
>>>
>>> $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
>>>
>>> +clean-files := *.dtb
>>> +
>>> quiet_cmd_uimage = UIMAGE $@
>>> cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \
>>> -C none -a $(LOADADDR) -e $(STARTADDR) \
>>> --
>>> 1.7.0.4
>>>
>>
>
>
>
next prev parent reply other threads:[~2011-11-07 6:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-05 6:19 [PATCH] distclean: Remove generated .dtb files Dirk Behme
2011-11-06 18:38 ` Grant Likely
2011-11-06 18:42 ` Grant Likely
2011-11-07 6:25 ` Dirk Behme [this message]
2011-11-07 13:51 ` Rob Herring
2011-11-08 17:20 ` Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB779CF.4040007@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).