From mboxrd@z Thu Jan 1 00:00:00 1970 From: dirk.behme@googlemail.com (Dirk Behme) Date: Mon, 07 Nov 2011 07:25:19 +0100 Subject: [PATCH] distclean: Remove generated .dtb files In-Reply-To: References: <1320473955-4500-1-git-send-email-dirk.behme@de.bosch.com> <20111106183802.GB2546@ponder.secretlab.ca> Message-ID: <4EB779CF.4040007@googlemail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06.11.2011 19:42, Grant Likely wrote: > On Sun, Nov 6, 2011 at 11:38 AM, Grant Likely wrote: >> On Sat, Nov 05, 2011 at 07:19:15AM +0100, Dirk Behme wrote: >>> The patch 'arm/dt: Add dtb make rule' adds support to >>> create a .dtb file. But this is never removed afterwards. >>> Remove the generated .dtb file if 'distclean' is called. >>> >>> Signed-off-by: Dirk Behme >>> CC: Rob Herring >>> CC: Shawn Guo >>> CC: Jason Liu >>> CC: Grant Likely >> >> Acked-by: Grant Likely > > ... although why are only the .dtb files needed in the clean list? > How are the other built files cleaned? 'make clean' does remove the > other images, but I don't know what the mechanism is. A lot of stuff is removed by the top level Makefile [1]. But as the patch "arm/dt: Add dtb make rule" adds the .dtb generation to arch/arm/boot/Makefile, we thought it would be a good place to add the removal of that file there, too. Hmm, not sure if this answers your question, though ;) Best regards Dirk [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=Makefile;h=ed25c5b35470dc2035f8b024994fa6cb7cecaca6;hb=HEAD#l1188 >> >>> --- >>> arch/arm/boot/Makefile | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile >>> index 1cd9b0a..08f0d35 100644 >>> --- a/arch/arm/boot/Makefile >>> +++ b/arch/arm/boot/Makefile >>> @@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts >>> >>> $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y)) >>> >>> +clean-files := *.dtb >>> + >>> quiet_cmd_uimage = UIMAGE $@ >>> cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \ >>> -C none -a $(LOADADDR) -e $(STARTADDR) \ >>> -- >>> 1.7.0.4 >>> >> > > >