From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 2/4] drivers/i2c/busses/i2c-at91.c: add new driver
Date: Tue, 08 Nov 2011 16:15:10 +0100 [thread overview]
Message-ID: <4EB9477E.8070002@atmel.com> (raw)
In-Reply-To: <20111108144115.GH20728@legolas.emea.dhcp.ti.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/08/2011 03:41 PM, Felipe Balbi :
>> + if (cpu_is_at91rm9200()) { /* AT91RM9200 Errata #22 */
>
> I don't think you should be using cpu_is_* on drivers.
It is a common pattern in at91 drivers and has worked for ages.
Do you think it is related to the need to be able to compile the
driver for any SoC in the case of multi-SoC zImage support?
Best regards,
- --
Nicolas Ferre
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJOuUd1AAoJEAf03oE53VmQs9UH/i+pKZlIN7lNb+sHvqHJhiUK
zqvPObtSo2Y78dODM4Qf/WrJP/jBW4FUAx60kBlEBzWAD2aef1D078POAOVhcVdH
Gj76Z+O5tF9H9YPcn/9HGyA42kL3NZu43ibywsvbUmX1O2LbtmX49bGOjArYSyXQ
sN4F8+QJnkMQfmMNjYgG0WfhMyWnp15W4QWq+frk2Kq0nXjiuozqr9goq8/LVRZc
aSToJUUJqsfk/bEGBAF6RmNxRIu2AMNpKQZS9a1gOZA/mAfSZrT9zQE6EZVXJDVr
VVck4KlhHBR3JU6AEh0CtoRgfZxsZyzS2RNUDyF7dq+8VsNiNpajSL8S2ILanZc=
=iqlm
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-11-08 15:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1320753142.git.n.voss@weinmann.de>
[not found] ` <458dd879d1fcdfc093e038426a581d86d30ecd5e.1320753142.git.n.voss@weinmann.de>
2011-11-08 14:36 ` [PATCH V3 1/4] drivers/i2c/busses/i2c-at91.c: remove broken driver Felipe Balbi
[not found] ` <7bdd6b456b0e055441cb25634c8cb6d483718f6c.1320753142.git.n.voss@weinmann.de>
2011-11-08 14:41 ` [PATCH V3 2/4] drivers/i2c/busses/i2c-at91.c: add new driver Felipe Balbi
2011-11-08 15:15 ` Nicolas Ferre [this message]
2011-11-08 15:23 ` Felipe Balbi
2011-11-08 18:29 ` Russell King - ARM Linux
2011-11-08 18:44 ` Felipe Balbi
2011-11-08 18:55 ` Russell King - ARM Linux
2011-11-08 19:02 ` Felipe Balbi
2011-11-08 19:39 ` Russell King - ARM Linux
2011-11-08 19:58 ` Felipe Balbi
2011-11-08 21:14 ` Russell King - ARM Linux
2011-11-08 15:35 ` Voss, Nikolaus
2011-11-08 15:40 ` Felipe Balbi
2011-11-08 15:49 ` Voss, Nikolaus
2011-11-08 18:06 ` Felipe Balbi
2011-11-08 22:50 ` Ryan Mallon
2011-11-09 16:01 ` Voss, Nikolaus
2011-11-09 19:11 ` Russell King - ARM Linux
2011-11-08 23:58 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB9477E.8070002@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).