From: rmallon@gmail.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 2/4] drivers/i2c/busses/i2c-at91.c: add new driver
Date: Wed, 09 Nov 2011 10:58:15 +1100 [thread overview]
Message-ID: <4EB9C217.1010100@gmail.com> (raw)
In-Reply-To: <7bdd6b456b0e055441cb25634c8cb6d483718f6c.1320753142.git.n.voss@weinmann.de>
On 08/11/11 21:49, Nikolaus Voss wrote:
> This driver has the following properties compared to the old driver:
> 1. Support for multiple interfaces.
> 2. Interrupt driven I/O as opposed to polling/busy waiting.
> 3. Support for _one_ repeated start (Sr) condition, which is enough
> for most real-world applications including all SMBus transfer types.
> (The hardware does not support issuing arbitrary Sr conditions on the
> bus.)
>
> Tested on Atmel G45 with BQ20Z80 battery SMBus client.
>
> Signed-off-by: Nikolaus Voss <n.voss@weinmann.de>
<snip>
> + dev->clk = clk_get(&pdev->dev, "twi_clk");
> + if (IS_ERR(dev->clk)) {
> + dev_err(&pdev->dev, "no clock defined\n");
> + rc = -ENODEV;
> + goto err_free_mem;
> + }
> + clk_enable(dev->clk);
There are now dummy clk_prepare/unprepare functions in
include/linux/clk.h, so you should be using them in this driver to
future proof it.
~Ryan
prev parent reply other threads:[~2011-11-08 23:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1320753142.git.n.voss@weinmann.de>
[not found] ` <458dd879d1fcdfc093e038426a581d86d30ecd5e.1320753142.git.n.voss@weinmann.de>
2011-11-08 14:36 ` [PATCH V3 1/4] drivers/i2c/busses/i2c-at91.c: remove broken driver Felipe Balbi
[not found] ` <7bdd6b456b0e055441cb25634c8cb6d483718f6c.1320753142.git.n.voss@weinmann.de>
2011-11-08 14:41 ` [PATCH V3 2/4] drivers/i2c/busses/i2c-at91.c: add new driver Felipe Balbi
2011-11-08 15:15 ` Nicolas Ferre
2011-11-08 15:23 ` Felipe Balbi
2011-11-08 18:29 ` Russell King - ARM Linux
2011-11-08 18:44 ` Felipe Balbi
2011-11-08 18:55 ` Russell King - ARM Linux
2011-11-08 19:02 ` Felipe Balbi
2011-11-08 19:39 ` Russell King - ARM Linux
2011-11-08 19:58 ` Felipe Balbi
2011-11-08 21:14 ` Russell King - ARM Linux
2011-11-08 15:35 ` Voss, Nikolaus
2011-11-08 15:40 ` Felipe Balbi
2011-11-08 15:49 ` Voss, Nikolaus
2011-11-08 18:06 ` Felipe Balbi
2011-11-08 22:50 ` Ryan Mallon
2011-11-09 16:01 ` Voss, Nikolaus
2011-11-09 19:11 ` Russell King - ARM Linux
2011-11-08 23:58 ` Ryan Mallon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB9C217.1010100@gmail.com \
--to=rmallon@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).