From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] spi/pl022: skip default configuration before suspending
Date: Wed, 9 Nov 2011 16:25:04 +0530 [thread overview]
Message-ID: <4EBA5C08.1040709@st.com> (raw)
In-Reply-To: <1320835154-31303-1-git-send-email-linus.walleij@stericsson.com>
On 11/9/2011 4:09 PM, Linus WALLEIJ wrote:
> From: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
>
> The loading of the default configuration before suspending has
> been in the driver since its inception, but it is not really
> needed. Especially so since we take to all the trouble of
> enabling and disabling power and clock just to do this. Let's
> scrap this now.
>
> Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/spi/spi-pl022.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
> index fa3eaae..bffad2a 100644
> --- a/drivers/spi/spi-pl022.c
> +++ b/drivers/spi/spi-pl022.c
> @@ -2314,12 +2314,7 @@ static int pl022_suspend(struct device *dev)
> return status;
> }
>
> - amba_vcore_enable(pl022->adev);
> - amba_pclk_enable(pl022->adev);
> - load_ssp_default_config(pl022);
> - amba_pclk_disable(pl022->adev);
> - amba_vcore_disable(pl022->adev);
> - dev_dbg(dev, "suspended\n");
> + dev_dbg(&adev->dev, "suspended\n");
why adev->dev instead of dev?
> return 0;
> }
>
--
viresh
next prev parent reply other threads:[~2011-11-09 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 10:39 [PATCH 4/6] spi/pl022: skip default configuration before suspending Linus Walleij
2011-11-09 10:55 ` Viresh Kumar [this message]
2011-11-09 12:31 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBA5C08.1040709@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox