linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: gic: allow GIC to support non-banked setups
Date: Tue, 15 Nov 2011 18:40:14 +0000	[thread overview]
Message-ID: <4EC2B20E.9070503@arm.com> (raw)
In-Reply-To: <4EC2A2EB.6010307@gmail.com>

On 15/11/11 17:35, Rob Herring wrote:
>>> On 11/15/2011 06:17 AM, Marc Zyngier wrote:
>>>> The GIC support code is heavily using the fact that hardware
>>>> implementations are exposing banked registers. Unfortunately, it
>>>> looks like at least one GIC implementation (EXYNOS) offers both
>>>> the distributor and the CPU interfaces at different addresses,
>>>> depending on the CPU.
>>>>
>>>> This problem is solved by allowing the distributor and CPU interface
>>>> addresses to be per-cpu variables for the platforms that require it.
>>>> The EXYNOS code is updated not to mess with the GIC internals while
>>>> handling interrupts, and struct gic_chip_data is back to being private.
>>>> The DT binding for the gic is updated to allow an optional "cpu-offset"
>>>> value, which is used to compute the various base addresses.
>>>>
>>>> Finally, a new config option (GIC_NON_BANKED) is used to control this
>>>> feature, so the overhead is only present on kernels compiled with
>>>> support for EXYNOS.
>>>>
>>>> Tested on Origen (EXYNOS4) and Panda (OMAP4).
>>>>
>>>> Cc: Kukjin Kim <kgene.kim@samsung.com>
>>>> Cc: Rob Herring <robherring2@gmail.com>
>>>> Cc: Will Deacon <will.deacon@arm.com>
>>>> Cc: Thomas Abraham <thomas.abraham@linaro.org>
>>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>>>> ---
>>>> This is a minor update on the previous version, simply adding a
>>>> config option so that normal platforms don't have to pay the
>>>> price of the get_base() indirection.
>>>>
>>>> Any comment is welcome, specially on the DT binding update.
>>>>
>>>>  Documentation/devicetree/bindings/arm/gic.txt |    4 +
>>>>  arch/arm/common/Kconfig                       |    3 +
>>>>  arch/arm/common/gic.c                         |  133 +++++++++++++++++++++----
>>>>  arch/arm/include/asm/hardware/gic.h           |   24 ++---
>>>>  arch/arm/mach-exynos/cpu.c                    |   16 +---
>>>>  arch/arm/mach-exynos/platsmp.c                |   28 +-----
>>>>  arch/arm/plat-s5p/Kconfig                     |    1 +
>>>>  7 files changed, 132 insertions(+), 77 deletions(-)
>>>>
> 
> So you can add my ack:
> 
> Acked-by: Rob Herring <rob.herring@calxeda.com>

Thanks Rob!

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2011-11-15 18:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15 12:17 [PATCH v3] ARM: gic: allow GIC to support non-banked setups Marc Zyngier
2011-11-15 13:37 ` Rob Herring
2011-11-15 14:16   ` Marc Zyngier
2011-11-15 17:35     ` Rob Herring
2011-11-15 18:40       ` Marc Zyngier [this message]
2011-11-17  4:52 ` Thomas Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC2B20E.9070503@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).