From: leif.lindholm@arm.com (Leif Lindholm)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] [RFC] Use generic ARM instruction set condition code checks for kprobes.
Date: Fri, 25 Nov 2011 13:29:13 +0000 [thread overview]
Message-ID: <4ECF9829.8010101@arm.com> (raw)
In-Reply-To: <1322163625.2233.53.camel@computer2>
On 11/24/11 19:40, Tixy wrote:
>> Now, disabling the SWP emulation, it still fails - but at least not as
>> an oops this time:
>> <<<
>> FAIL: test memory differs
>> FAIL: Test strd r2, [r3], r4
>> FAIL: Scenario 0
...
>> FATAL: Error inserting test_kprobes
>>
> The kprobes instruction emulation has stored the original value of r3
> into memory, whereas the real instruction has store the updated value of
> r3. Either this instruction form is UNPREDICTABLE, in which case the
> test code should not be trying to test it, otherwise the instruction
> emulation code needs fixing. Either way, a patch is needed. I'll look
> into this.
Yes, this instruction form is UNPREDICTABLE, and some quick experiments
show that it behaves differently on for example Cortex-A8 and Cortex-A9.
/
Leif
next prev parent reply other threads:[~2011-11-25 13:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 18:30 [PATCH 1/4] [RFC] Add generic ARM instruction set condition code checks Leif Lindholm
2011-11-21 18:30 ` [PATCH 2/4] [RFC] Use generic ARM instruction set condition code checks for nwfpe Leif Lindholm
2011-11-21 18:30 ` [PATCH 3/4] [RFC] Add condition code checking to SWP emulation handler Leif Lindholm
2011-11-21 18:53 ` Will Deacon
2011-11-21 18:31 ` [PATCH 4/4] [RFC] Use generic ARM instruction set condition code checks for kprobes Leif Lindholm
2011-11-22 9:13 ` Tixy
[not found] ` <4ECE78B6.9040408@arm.com>
2011-11-24 19:40 ` Tixy
2011-11-25 13:29 ` Leif Lindholm [this message]
2011-11-21 18:52 ` [PATCH 1/4] [RFC] Add generic ARM instruction set condition code checks Will Deacon
2011-11-21 19:08 ` Russell King - ARM Linux
2011-11-22 10:18 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECF9829.8010101@arm.com \
--to=leif.lindholm@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).