* [PATCH] arm, da8xx, mmc: set second MMC controllers default queue
@ 2011-12-04 9:33 Heiko Schocher
2011-12-04 12:15 ` Sergei Shtylyov
2011-12-04 13:25 ` Rajashekhara, Sudhakar
0 siblings, 2 replies; 6+ messages in thread
From: Heiko Schocher @ 2011-12-04 9:33 UTC (permalink / raw)
To: linux-arm-kernel
The MMC driver allocates channels with EVENTQ_DEFAULT they
get put into EVENTQ_1 which the second EDMA controller does
not have and hence transfers stall. This is tried to fix
in commit f23fe857bbea393b4b94fe2218c98d934bd3d4cf
from Ido Yariv, but missed a fix for the second MMC
controller on da850.
Signed-off-by: Heiko Schocher <hs@denx.de>
Signed-off-by: juha.kuikka at gmail.com
Reported-by: juha.kuikka at gmail.com
Cc: linux-mmc at vger.kernel.org
Cc: davinci-linux-open-source at linux.davincidsp.com
Cc: Rajashekhara, Sudhakar <sudhakar.raj@ti.com>
Cc: Ido Yariv <ido@wizery.com>
Cc: Sekhar Nori <nsekhar@ti.com>
Cc: Wolfgang Denk <wd@denx.de>
---
arch/arm/mach-davinci/dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-davinci/dma.c b/arch/arm/mach-davinci/dma.c
index da90103..e10a251 100644
--- a/arch/arm/mach-davinci/dma.c
+++ b/arch/arm/mach-davinci/dma.c
@@ -1513,7 +1513,7 @@ static int __init edma_probe(struct platform_device *pdev)
* started by the codec engine will not cause audio defects.
*/
for (i = 0; i < edma_cc[j]->num_channels; i++)
- map_dmach_queue(j, i, EVENTQ_1);
+ map_dmach_queue(j, i, info[j]->default_queue);
queue_tc_mapping = info[j]->queue_tc_mapping;
queue_priority_mapping = info[j]->queue_priority_mapping;
--
1.7.6.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm, da8xx, mmc: set second MMC controllers default queue
2011-12-04 9:33 [PATCH] arm, da8xx, mmc: set second MMC controllers default queue Heiko Schocher
@ 2011-12-04 12:15 ` Sergei Shtylyov
2011-12-04 13:25 ` Rajashekhara, Sudhakar
1 sibling, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2011-12-04 12:15 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 04-12-2011 13:33, Heiko Schocher wrote:
> The MMC driver allocates channels with EVENTQ_DEFAULT they
Missed comma before "they"?
> get put into EVENTQ_1 which the second EDMA controller does
> not have and hence transfers stall. This is tried to fix
> in commit f23fe857bbea393b4b94fe2218c98d934bd3d4cf
Please also specify that commit's summary in parens.
> from Ido Yariv, but missed a fix for the second MMC
> controller on da850.
> Signed-off-by: Heiko Schocher<hs@denx.de>
> Signed-off-by: juha.kuikka at gmail.com
> Reported-by: juha.kuikka at gmail.com
> Cc: linux-mmc at vger.kernel.org
> Cc: davinci-linux-open-source at linux.davincidsp.com
> Cc: Rajashekhara, Sudhakar<sudhakar.raj@ti.com>
> Cc: Ido Yariv<ido@wizery.com>
> Cc: Sekhar Nori<nsekhar@ti.com>
> Cc: Wolfgang Denk<wd@denx.de>
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm, da8xx, mmc: set second MMC controllers default queue
2011-12-04 9:33 [PATCH] arm, da8xx, mmc: set second MMC controllers default queue Heiko Schocher
2011-12-04 12:15 ` Sergei Shtylyov
@ 2011-12-04 13:25 ` Rajashekhara, Sudhakar
2011-12-05 10:46 ` Heiko Schocher
1 sibling, 1 reply; 6+ messages in thread
From: Rajashekhara, Sudhakar @ 2011-12-04 13:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Sun, Dec 04, 2011 at 15:03:30, Heiko Schocher wrote:
> The MMC driver allocates channels with EVENTQ_DEFAULT they
> get put into EVENTQ_1 which the second EDMA controller does
> not have and hence transfers stall. This is tried to fix
> in commit f23fe857bbea393b4b94fe2218c98d934bd3d4cf
> from Ido Yariv, but missed a fix for the second MMC
> controller on da850.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Signed-off-by: juha.kuikka at gmail.com
> Reported-by: juha.kuikka at gmail.com
> Cc: linux-mmc at vger.kernel.org
> Cc: davinci-linux-open-source at linux.davincidsp.com
> Cc: Rajashekhara, Sudhakar <sudhakar.raj@ti.com>
> Cc: Ido Yariv <ido@wizery.com>
> Cc: Sekhar Nori <nsekhar@ti.com>
> Cc: Wolfgang Denk <wd@denx.de>
> ---
> arch/arm/mach-davinci/dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/dma.c b/arch/arm/mach-davinci/dma.c
> index da90103..e10a251 100644
> --- a/arch/arm/mach-davinci/dma.c
> +++ b/arch/arm/mach-davinci/dma.c
> @@ -1513,7 +1513,7 @@ static int __init edma_probe(struct platform_device *pdev)
> * started by the codec engine will not cause audio defects.
> */
> for (i = 0; i < edma_cc[j]->num_channels; i++)
> - map_dmach_queue(j, i, EVENTQ_1);
> + map_dmach_queue(j, i, info[j]->default_queue);
>
> queue_tc_mapping = info[j]->queue_tc_mapping;
> queue_priority_mapping = info[j]->queue_priority_mapping;
Acked-by: Rajashekhara, Sudhakar <sudhakar.raj@ti.com>
Regards,
Sudhakar
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm, da8xx, mmc: set second MMC controllers default queue
2011-12-04 13:25 ` Rajashekhara, Sudhakar
@ 2011-12-05 10:46 ` Heiko Schocher
2011-12-06 19:09 ` Nori, Sekhar
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Schocher @ 2011-12-05 10:46 UTC (permalink / raw)
To: linux-arm-kernel
Hello Rajashekhara,
Rajashekhara, Sudhakar wrote:
> Hi,
>
> On Sun, Dec 04, 2011 at 15:03:30, Heiko Schocher wrote:
>> The MMC driver allocates channels with EVENTQ_DEFAULT they
>> get put into EVENTQ_1 which the second EDMA controller does
>> not have and hence transfers stall. This is tried to fix
>> in commit f23fe857bbea393b4b94fe2218c98d934bd3d4cf
>> from Ido Yariv, but missed a fix for the second MMC
>> controller on da850.
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> Signed-off-by: juha.kuikka at gmail.com
>> Reported-by: juha.kuikka at gmail.com
>> Cc: linux-mmc at vger.kernel.org
>> Cc: davinci-linux-open-source at linux.davincidsp.com
>> Cc: Rajashekhara, Sudhakar <sudhakar.raj@ti.com>
>> Cc: Ido Yariv <ido@wizery.com>
>> Cc: Sekhar Nori <nsekhar@ti.com>
>> Cc: Wolfgang Denk <wd@denx.de>
>> ---
>> arch/arm/mach-davinci/dma.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/dma.c b/arch/arm/mach-davinci/dma.c
>> index da90103..e10a251 100644
>> --- a/arch/arm/mach-davinci/dma.c
>> +++ b/arch/arm/mach-davinci/dma.c
>> @@ -1513,7 +1513,7 @@ static int __init edma_probe(struct platform_device *pdev)
>> * started by the codec engine will not cause audio defects.
>> */
>> for (i = 0; i < edma_cc[j]->num_channels; i++)
>> - map_dmach_queue(j, i, EVENTQ_1);
>> + map_dmach_queue(j, i, info[j]->default_queue);
>>
>> queue_tc_mapping = info[j]->queue_tc_mapping;
>> queue_priority_mapping = info[j]->queue_priority_mapping;
>
> Acked-by: Rajashekhara, Sudhakar <sudhakar.raj@ti.com>
Thanks, but as Ido commented, this patch is no longer necessary, sorry
for the noise.
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm, da8xx, mmc: set second MMC controllers default queue
2011-12-05 10:46 ` Heiko Schocher
@ 2011-12-06 19:09 ` Nori, Sekhar
2011-12-06 19:15 ` Hernandez, Alejandro
0 siblings, 1 reply; 6+ messages in thread
From: Nori, Sekhar @ 2011-12-06 19:09 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Dec 05, 2011 at 16:16:33, Heiko Schocher wrote:
>
> Thanks, but as Ido commented, this patch is no longer necessary, sorry
> for the noise.
>
It doesn't look like Ido's comment reached me or the archives. Can you
please forward it?
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm, da8xx, mmc: set second MMC controllers default queue
2011-12-06 19:09 ` Nori, Sekhar
@ 2011-12-06 19:15 ` Hernandez, Alejandro
0 siblings, 0 replies; 6+ messages in thread
From: Hernandez, Alejandro @ 2011-12-06 19:15 UTC (permalink / raw)
To: linux-arm-kernel
Sekhar,
Do you still want me to try the patch?
Thanks,
Alejandro
-----Original Message-----
From: davinci-linux-open-source-bounces@linux.davincidsp.com [mailto:davinci-linux-open-source-bounces at linux.davincidsp.com] On Behalf Of Nori, Sekhar
Sent: Tuesday, December 06, 2011 2:10 PM
To: hs at denx.de; Rajashekhara, Sudhakar
Cc: davinci-linux-open-source at linux.davincidsp.com; Wolfgang Denk; linux-mmc at vger.kernel.org; Ido Yariv; linux-arm-kernel at lists.infradead.org
Subject: RE: [PATCH] arm, da8xx, mmc: set second MMC controllers default queue
On Mon, Dec 05, 2011 at 16:16:33, Heiko Schocher wrote:
>
> Thanks, but as Ido commented, this patch is no longer necessary, sorry
> for the noise.
>
It doesn't look like Ido's comment reached me or the archives. Can you
please forward it?
Thanks,
Sekhar
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source at linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-06 19:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-04 9:33 [PATCH] arm, da8xx, mmc: set second MMC controllers default queue Heiko Schocher
2011-12-04 12:15 ` Sergei Shtylyov
2011-12-04 13:25 ` Rajashekhara, Sudhakar
2011-12-05 10:46 ` Heiko Schocher
2011-12-06 19:09 ` Nori, Sekhar
2011-12-06 19:15 ` Hernandez, Alejandro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).