From: hs@denx.de (Heiko Schocher)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm, da8xx, mmc: set second MMC controllers default queue
Date: Mon, 05 Dec 2011 11:46:33 +0100 [thread overview]
Message-ID: <4EDCA109.2090204@denx.de> (raw)
In-Reply-To: <B6A220404B6BFC4BBD2AB91C54D39DF4029FE5@DBDE01.ent.ti.com>
Hello Rajashekhara,
Rajashekhara, Sudhakar wrote:
> Hi,
>
> On Sun, Dec 04, 2011 at 15:03:30, Heiko Schocher wrote:
>> The MMC driver allocates channels with EVENTQ_DEFAULT they
>> get put into EVENTQ_1 which the second EDMA controller does
>> not have and hence transfers stall. This is tried to fix
>> in commit f23fe857bbea393b4b94fe2218c98d934bd3d4cf
>> from Ido Yariv, but missed a fix for the second MMC
>> controller on da850.
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> Signed-off-by: juha.kuikka at gmail.com
>> Reported-by: juha.kuikka at gmail.com
>> Cc: linux-mmc at vger.kernel.org
>> Cc: davinci-linux-open-source at linux.davincidsp.com
>> Cc: Rajashekhara, Sudhakar <sudhakar.raj@ti.com>
>> Cc: Ido Yariv <ido@wizery.com>
>> Cc: Sekhar Nori <nsekhar@ti.com>
>> Cc: Wolfgang Denk <wd@denx.de>
>> ---
>> arch/arm/mach-davinci/dma.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/dma.c b/arch/arm/mach-davinci/dma.c
>> index da90103..e10a251 100644
>> --- a/arch/arm/mach-davinci/dma.c
>> +++ b/arch/arm/mach-davinci/dma.c
>> @@ -1513,7 +1513,7 @@ static int __init edma_probe(struct platform_device *pdev)
>> * started by the codec engine will not cause audio defects.
>> */
>> for (i = 0; i < edma_cc[j]->num_channels; i++)
>> - map_dmach_queue(j, i, EVENTQ_1);
>> + map_dmach_queue(j, i, info[j]->default_queue);
>>
>> queue_tc_mapping = info[j]->queue_tc_mapping;
>> queue_priority_mapping = info[j]->queue_priority_mapping;
>
> Acked-by: Rajashekhara, Sudhakar <sudhakar.raj@ti.com>
Thanks, but as Ido commented, this patch is no longer necessary, sorry
for the noise.
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-12-05 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-04 9:33 [PATCH] arm, da8xx, mmc: set second MMC controllers default queue Heiko Schocher
2011-12-04 12:15 ` Sergei Shtylyov
2011-12-04 13:25 ` Rajashekhara, Sudhakar
2011-12-05 10:46 ` Heiko Schocher [this message]
2011-12-06 19:09 ` Nori, Sekhar
2011-12-06 19:15 ` Hernandez, Alejandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDCA109.2090204@denx.de \
--to=hs@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).