linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hong.xu@atmel.com (Hong Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] MTD: atmel_nand: Update Kconfig to support PMECC
Date: Tue, 13 Dec 2011 09:58:56 +0800	[thread overview]
Message-ID: <4EE6B160.3000201@atmel.com> (raw)
In-Reply-To: <4EE6A6DF.4@atmel.com>

Hi Artem,

On 12/13/2011 09:14 AM, Hong Xu wrote:
> Hi David,

Sorry, this shall be Artem :-)

>
> On 12/13/2011 04:58 AM, Artem Bityutskiy wrote:
>  > On Thu, 2011-12-08 at 14:53 +0800, Hong Xu wrote:
>  > > +config MTD_NAND_ATMEL_PMECC_HW
>  > > + bool "Programmable Hardware ECC (BCH code)"
>  > > + depends on ARCH_AT91SAM9X5 || ARCH_AT91SAM9N12
>  > > + help
>  > > + Use Programmable Hardware ECC (PMECC) controller.
>  > > +
>  > > + The PMECC Controller is a programmable binary BCH (Bose, Chaudhuri
>  > > + and Hocquenghem) encoder/decoder. This controller can be used to
>  > > + generate redundancy information for both SLC and MLC NAND Flash
>  > > + devices.
>  > > +
>  > > + NB : hardware and software ECC schemes are incompatible.
>  > > + If you switch from one to another, you'll have to erase your
>  > > + mtd partition.
>  >
>  > Does it have to be a config option, can we avoid adding config options
>  > uless we really have to?
>
> Agree. The original MTD_NAND_ATMEL_ECC_HW can be reused. In driver, if
> the SoC has PMECC, it'll be used.

PMECC is not compatible with the old HW ECC engine. It currently needs 
around 700 lines of C code to make it work. If we do not have a way to 
exclude the PMECC related code at compiling time, my quick testing shows 
that the driver code size will be doubled if some old SoCs do not 
support it. This sounds not good. What's your opinion?

Thanks.

BR,
Eric

> Thanks.
>
> BR,
> Eric
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>

  reply	other threads:[~2011-12-13  1:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08  6:53 [PATCH 1/2] MTD: atmel_nand: Update Kconfig to support PMECC Hong Xu
2011-12-08  6:53 ` [PATCH 2/2] MTD: atmel_nand: Update driver code to support Programmable HW ECC controller Hong Xu
2011-12-12 20:58 ` [PATCH 1/2] MTD: atmel_nand: Update Kconfig to support PMECC Artem Bityutskiy
2011-12-13  1:14   ` Hong Xu
2011-12-13  1:58     ` Hong Xu [this message]
2011-12-17 15:33       ` Artem Bityutskiy
2011-12-19  1:58         ` Hong Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE6B160.3000201@atmel.com \
    --to=hong.xu@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).