From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: vmlinux.lds.S: do not hardcode cacheline size as 32 bytes
Date: Thu, 15 Dec 2011 11:00:41 -0800 [thread overview]
Message-ID: <4EEA43D9.9040700@codeaurora.org> (raw)
In-Reply-To: <1323799572-5641-1-git-send-email-will.deacon@arm.com>
On 12/13/11 10:06, Will Deacon wrote:
> The linker script assumes a cacheline size of 32 bytes when aligning
> the .data..cacheline_aligned and .data..percpu sections.
>
> This patch updates the script to use L1_CACHE_BYTES, which should be set
> to 64 on platforms that require it.
>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
>
> I'm posting this as an RFC because, whilst this fixes a bug, it looks
> like many platforms don't select ARM_L1_CACHE_SHIFT_6 when they should
> (all Cortex-A8 platforms should select this, for example).
What are the implications of not having cache aligned data? Is it a
performance impact or something more?
> @@ -205,7 +206,7 @@ SECTIONS
> #endif
>
> NOSAVE_DATA
> - CACHELINE_ALIGNED_DATA(32)
> + CACHELINE_ALIGNED_DATA(L1_CACHE_BYTES)
> READ_MOSTLY_DATA(32)
Does READ_MOSTLY_DATA also need to be cache aligned? At least powerpc is
doing that.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-12-15 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 18:06 [RFC PATCH] ARM: vmlinux.lds.S: do not hardcode cacheline size as 32 bytes Will Deacon
2011-12-15 19:00 ` Stephen Boyd [this message]
2011-12-15 23:22 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEA43D9.9040700@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).