linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shinya.kuribayashi.px@renesas.com (Shinya Kuribayashi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: errata: Faulty logic in the Store Buffer may lead to data corruption
Date: Tue, 20 Dec 2011 17:38:09 +0900	[thread overview]
Message-ID: <4EF04971.4060406@renesas.com> (raw)
In-Reply-To: <4EF04923.50203@renesas.com>

This is an update for the existing software workaround for the 743622
Cortex-A9 erratum (475d92fc6e ARM: 6416/1: errata: faulty hazard checking
in the Store Buffer may lead to data corruption).

According to the later errata notice updates, this erratum turned out
to be present not only in (r2p0..r2p2), but in all r2p* revisions.
Also the errata title is corrected to indicate that the errata leads to
data corruption, and not to a processor deadlock as sometimes mentioned
in previous revisions of the document.

Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
---
 arch/arm/Kconfig      |    4 ++--
 arch/arm/mm/proc-v7.S |    4 +---
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 776d76b..ed474b6 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1268,11 +1268,11 @@ config PL310_ERRATA_727915
 	  Invalidate by Way operation.
 
 config ARM_ERRATA_743622
-	bool "ARM errata: Faulty hazard checking in the Store Buffer may lead to data corruption"
+	bool "ARM errata: Faulty logic in the Store Buffer may lead to data corruption"
 	depends on CPU_V7
 	help
 	  This option enables the workaround for the 743622 Cortex-A9
-	  (r2p0..r2p2) erratum. Under very rare conditions, a faulty
+	  (r2p0..r2p10) erratum. Under very rare conditions, a faulty
 	  optimisation in the Cortex-A9 Store Buffer may lead to data
 	  corruption. This workaround sets a specific bit in the diagnostic
 	  register of the Cortex-A9 which disables the Store Buffer
diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
index 8f8fced..9f1912d 100644
--- a/arch/arm/mm/proc-v7.S
+++ b/arch/arm/mm/proc-v7.S
@@ -355,9 +355,7 @@ __v7_setup:
 	mcreq	p15, 0, r10, c15, c0, 1		@ write diagnostic register
 #endif
 #ifdef CONFIG_ARM_ERRATA_743622
-	teq	r6, #0x20			@ present in r2p0
-	teqne	r6, #0x21			@ present in r2p1
-	teqne	r6, #0x22			@ present in r2p2
+	teq	r5, #0x00200000			@ present in r2p*
 	mrceq	p15, 0, r10, c15, c0, 1		@ read diagnostic register
 	orreq	r10, r10, #1 << 6		@ set bit #6
 	mcreq	p15, 0, r10, c15, c0, 1		@ write diagnostic register
-- 
1.7.8

  parent reply	other threads:[~2011-12-20  8:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-20  8:36 ARM errata corrections Shinya Kuribayashi
2011-12-20  8:37 ` [PATCH] ARM: errata: Update the workaround for the 742231 Cortex-A9 erratum Shinya Kuribayashi
2011-12-20 14:15   ` Catalin Marinas
2011-12-20  8:38 ` Shinya Kuribayashi [this message]
2011-12-20 10:26   ` [PATCH] ARM: errata: Faulty logic in the Store Buffer may lead to data corruption Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF04971.4060406@renesas.com \
    --to=shinya.kuribayashi.px@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).