From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MTD/GPMI bugfix : reset the BCH module when it is not MX23
Date: Fri, 30 Dec 2011 16:17:54 +0800 [thread overview]
Message-ID: <4EFD73B2.7020801@freescale.com> (raw)
In-Reply-To: <20111230074643.GA3018@tarshish>
Hi Baruch:
> Hi Huang,
>
> On Fri, Dec 30, 2011 at 11:28:10AM +0800, Huang Shijie wrote:
>> In MX28, if we do not reset the BCH module. The BCH module may
>> becomes unstable when the board reboots for several thousands times.
>> This bug has been catched in customer's production.
>>
>> The patch adds some comments, and fixes it now.
>>
>> Also change gpmi_reset_block() to static.
>>
>> Signed-off-by: Huang Shijie<b32955@freescale.com>
>> ---
> [snip]
>
>> - ret = gpmi_reset_block(r->bch_regs, true);
>> + /* The bug only exits in mx23, the following chips fix it. */
>> + if (GPMI_IS_MX23(this))
>> + ret = gpmi_reset_block(r->bch_regs, true);
>> + else
>> + ret = gpmi_reset_block(r->bch_regs, false);
> This can be shortened to:
>
> ret = gpmi_reset_block(r->bch_regs, GPMI_IS_MX23(this));
thanks a lot.
I will use it in new patch.
Huang Shijie
>> if (ret)
>> goto err_out;
>>
>> --
>> 1.7.0.4
> baruch
>
prev parent reply other threads:[~2011-12-30 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 3:28 [PATCH] MTD/GPMI bugfix : reset the BCH module when it is not MX23 Huang Shijie
2011-12-30 7:46 ` Baruch Siach
2011-12-30 8:17 ` Huang Shijie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFD73B2.7020801@freescale.com \
--to=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).