From mboxrd@z Thu Jan  1 00:00:00 1970
From: b32955@freescale.com (Huang Shijie)
Date: Sat, 31 Dec 2011 13:48:00 +0800
Subject: [PATCH] MTD/GPMI : select more modules for GPMI by default
In-Reply-To: <20111231054432.GE12182@S2100-06.ap.freescale.net>
References: <1325220337-23165-1-git-send-email-b32955@freescale.com>
 <20111231054432.GE12182@S2100-06.ap.freescale.net>
Message-ID: <4EFEA210.30606@freescale.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

? 2011?12?31? 13:44, Shawn Guo ??:
> On Fri, Dec 30, 2011 at 12:45:37PM +0800, Huang Shijie wrote:
>> The gpmi-nand driver needs the mxs-dma driver. So select the
>> MXS_DMA by default. So does the MTD_CHAR.
>>
>> Signed-off-by: Huang Shijie<b32955@freescale.com>
>> ---
>>   drivers/mtd/nand/Kconfig |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>> index 07c4774..1b14a3a 100644
>> --- a/drivers/mtd/nand/Kconfig
>> +++ b/drivers/mtd/nand/Kconfig
>> @@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM
>>   config MTD_NAND_GPMI_NAND
>>           bool "GPMI NAND Flash Controller driver"
>>           depends on MTD_NAND&&  (SOC_IMX23 || SOC_IMX28)
>> +	select MXS_DMA
> We should probably have it depend on MXS_DMA rather than select it.
IMHO, I think `select` is better. :)
The MXS_DMA not only service for NAND, but SD card, etc.
In logic, the GPMI does not depends on MXS_DMA, the GPMI may use SDMA 
too(just in logically).


Best Regards
Huang Shijie

> Regards,
> Shawn
>
>> +	select MTD_CHAR
>>   	select MTD_PARTITIONS
>>   	select MTD_CMDLINE_PARTS
>>           help
>> -- 
>> 1.7.0.4