From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/8] Add common ARM cpuidle init code
Date: Tue, 03 Jan 2012 15:54:16 +0100 [thread overview]
Message-ID: <4F031698.4010501@linaro.org> (raw)
In-Reply-To: <201112081537.04789.arnd.bergmann@linaro.org>
On 12/08/2011 04:37 PM, Arnd Bergmann wrote:
> On Thursday 08 December 2011, Shawn Guo wrote:
>>>
>> With many drivers are being moved into drivers/* from arch/arm/mach-*
>> and arch/arm/plat-*, I'm wondering if we have any problem with doing
>> the same thing on cpuidle. If we can move these cpuidle drivers into
>> drivers/cpuidle (or drivers/idle, I'm not sure why two folders), that
>> will be the best place for such consolidation to me.
>>
>> Cc-ed linux-pm and Len Brown for helping understand.
>
> I think we should definitely move them into one of the two directories.
> The one thing making this a bit nasty is that many SoC implementation
> need to access some global registers for this and don't have a "device"
> that can be used for cpuidle with its own register ranges, but it's
> still better to have the code in a single place IMHO.
Yes, I agree. Moreover that will facilitate to factor out the code which
is spread all around the different architecture.
The places where there is the drivers cpuidle code are at drivers/idle,
driver/acpi, arch/arm, arch/sh/kernel/cpu/mobile/cpuidle, etc ...
IMHO, before doing some code factoring out, we should move all these
drivers to the cpuidle directory, no ?
drivers/idle/intel_idle.c => drivers/cpuidle/intel.c
drivers/acpi/processor_idle.c => drivers/cpuidle/acpi.c
arch/arm/mach-omap2/cpuidle34xx.c => drivers/cpuidle/omap-34xx.c
arch/arm/mach-omap2/cpuidle44xx.c => drivers/cpuidle/omap-44xx.c
arch/arm/mach-shmobile/cpuidle.c => drivers/cpuidle/arm-shmobile.c
arch/arm/mach-davinci/cpuidle.c => drivers/cpuidle/davinci.c
arch/arm/mach-at91/cpuidle.c => drivers/cpuidle/at91.c
arch/arm/mach-s3c64xx/cpuidle.c => drivers/cpuidle/s3c64xx.c
arch/arm/mach-exynos/cpuidle.c => drivers/cpuidle/exynos.c
arch/arm/mach-kirkwood/cpuidle.c => drivers/cpuidle/kirkwood.c
arch/arcm/mach-msm/idle.S => drivers/cpuidle/msm.S
That could be a first step and then we move the other archs which could
be a bit more tricky like the powerpc.
Does it make sense ?
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2012-01-03 14:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 4:38 [RFC PATCH 0/8] Add common ARM cpuidle init code Robert Lee
2011-12-06 4:38 ` [RFC PATCH 1/8] ARM: Add commonly used " Robert Lee
2011-12-06 11:47 ` Mark Brown
2011-12-08 17:34 ` Rob Lee
2011-12-09 8:25 ` Mark Brown
2011-12-06 15:06 ` Rob Herring
2011-12-08 21:46 ` Rob Lee
2011-12-09 13:54 ` Rob Herring
2011-12-09 15:55 ` Rob Lee
2011-12-09 19:48 ` Nicolas Pitre
2011-12-06 4:38 ` [RFC PATCH 2/8] ARM: at91: Replace init with new common ARM " Robert Lee
2011-12-06 4:38 ` [RFC PATCH 3/8] ARM: kirkwood: " Robert Lee
2011-12-06 4:38 ` [RFC PATCH 4/8] ARM: exynos: " Robert Lee
2011-12-06 4:38 ` [RFC PATCH 5/8] ARM: davinci: " Robert Lee
2011-12-06 4:38 ` [RFC PATCH 6/8] ARM: shmobile: " Robert Lee
2011-12-06 4:38 ` [RFC PATCH 7/8] ARM: imx: Add mx5 clock changes necessary for low power Robert Lee
2011-12-06 4:38 ` [RFC PATCH 8/8] ARM: imx: Add mx5 cpuidle implmentation Robert Lee
2011-12-08 14:56 ` [RFC PATCH 0/8] Add common ARM cpuidle init code Shawn Guo
2011-12-08 15:37 ` Arnd Bergmann
2012-01-03 14:54 ` Daniel Lezcano [this message]
2012-01-03 16:02 ` Arnd Bergmann
2012-01-04 9:17 ` Daniel Lezcano
2012-01-04 18:05 ` Rob Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F031698.4010501@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).