From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqdomain: Initialize number of IRQs for simple domains
Date: Fri, 06 Jan 2012 10:26:17 -0600 [thread overview]
Message-ID: <4F0720A9.8070400@gmail.com> (raw)
In-Reply-To: <20120106160744.GA7687@codeaurora.org>
On 01/06/2012 10:07 AM, David Brown wrote:
> On Fri, Jan 06, 2012 at 03:28:25PM +0100, Thierry Reding wrote:
>> diff --git a/arch/arm/mach-msm/board-msm8x60.c b/arch/arm/mach-msm/board-msm8x60.c
>> index 0a11342..a50c7e2 100644
>> --- a/arch/arm/mach-msm/board-msm8x60.c
>> +++ b/arch/arm/mach-msm/board-msm8x60.c
>> @@ -84,8 +84,11 @@ static void __init msm8x60_dt_init(void)
>>
>> node = of_find_matching_node_by_address(NULL, msm_dt_gic_match,
>> MSM8X60_QGIC_DIST_PHYS);
>> - if (node)
>> - irq_domain_add_simple(node, GIC_SPI_START);
>> + if (node) {
>> + struct irq_domain *domain = irq_domain_add_simple(node,
>> + GIC_SPI_START, NR_MSM_IRQS);
>> + WARN_ON(IS_ERR(domain));
>> + }
>>
>> if (of_machine_is_compatible("qcom,msm8660-surf")) {
>> printk(KERN_INFO "Init surf UART registers\n");
>
> This is probably a consequence of MSM not really being "simple", but
> just using that. However, NR_MSM_IRQS is only the number of IRQs on
> the MSM core. There are also GPIO irqs, and potentially board IRQs
> (the board has an I2C-based chip with a bunch of IRQ lines on it).
>
> The only define that captures this now is 'NR_IRQS', even though we're
> trying to get rid of that.
>
> Ultimately, the correct answer will be to get the various interrupt
> controllers using their own domains, but for now, this needs to be a
> larger value to avoid missing a bunch of the interrupts.
No. This should only be the number of interrupts for a controller as the
interrupt numbers in the device tree should be relative to a controller
and not the Linux virq number. The numbering in the dts needs to be
correct. You don't need a domain until you start getting the interrupts
from the dts.
Rob
next prev parent reply other threads:[~2012-01-06 16:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 14:28 [PATCH] irqdomain: Initialize number of IRQs for simple domains Thierry Reding
2012-01-06 14:36 ` Nicolas Ferre
2012-01-06 15:04 ` Grant Likely
2012-01-06 16:20 ` Thierry Reding
2012-01-06 21:34 ` Grant Likely
2012-01-07 11:40 ` Thierry Reding
2012-01-06 16:07 ` David Brown
2012-01-06 16:12 ` Thierry Reding
2012-01-06 16:26 ` Rob Herring [this message]
2012-01-06 18:52 ` David Brown
2012-01-06 16:58 ` Cousson, Benoit
2012-01-09 9:03 ` Thierry Reding
2012-01-07 5:58 ` Shawn Guo
2012-01-07 11:47 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0720A9.8070400@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).