From: FlorianSchandinat@gmx.de (Florian Tobias Schandinat)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes
Date: Mon, 09 Jan 2012 02:49:59 +0000 [thread overview]
Message-ID: <4F0A55D7.50707@gmx.de> (raw)
In-Reply-To: <87zke29yqj.fsf@macbook.be.48ers.dk>
Hi Peter,
On 01/05/2012 11:26 AM, Peter Korsgaard wrote:
>>>>>> "Peter" == Peter Korsgaard <jacmet@sunsite.dk> writes:
>
> Peter> Allow framebuffer to be configured in 16bit mode when panel is
> Peter> wired in (the default) BGR configuration, and don't claim to
> Peter> support 15bit input modes, which the LCD controller cannot
> Peter> handle.
>
> Ping? Nicolas, you added it to your at91-lcd branch - But it doesn't seem
> to have gone any further.
I could also take care of this patch but I'd prefer if it gets an Acked-by of
someone at Atmel (or someone else who knows the hardware) as I cannot really
tell whether it is correct.
Best regards,
Florian Tobias Schandinat
>
> Peter> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> Peter> ---
> Peter> drivers/video/atmel_lcdfb.c | 12 +++---------
> Peter> 1 files changed, 3 insertions(+), 9 deletions(-)
>
> Peter> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> Peter> index 7ca3eaf..143f6d9 100644
> Peter> --- a/drivers/video/atmel_lcdfb.c
> Peter> +++ b/drivers/video/atmel_lcdfb.c
> Peter> @@ -418,24 +418,18 @@ static int atmel_lcdfb_check_var(struct fb_var_screeninfo *var,
> var-> red.length = var->green.length = var->blue.length
> Peter> = var->bits_per_pixel;
> Peter> break;
> Peter> - case 15:
> Peter> case 16:
> Peter> if (sinfo->lcd_wiring_mode == ATMEL_LCDC_WIRING_RGB) {
> Peter> /* RGB:565 mode */
> var-> red.offset = 11;
> var-> blue.offset = 0;
> Peter> - var->green.length = 6;
> Peter> - } else if (sinfo->lcd_wiring_mode == ATMEL_LCDC_WIRING_RGB555) {
> Peter> - var->red.offset = 10;
> Peter> - var->blue.offset = 0;
> Peter> - var->green.length = 5;
> Peter> } else {
> Peter> - /* BGR:555 mode */
> Peter> + /* BGR:565 mode */
> var-> red.offset = 0;
> Peter> - var->blue.offset = 10;
> Peter> - var->green.length = 5;
> Peter> + var->blue.offset = 11;
> Peter> }
> var-> green.offset = 5;
> Peter> + var->green.length = 6;
> var-> red.length = var->blue.length = 5;
> Peter> break;
> Peter> case 32:
> Peter> --
> Peter> 1.7.6.3
>
next prev parent reply other threads:[~2012-01-09 2:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 14:52 [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes Peter Korsgaard
2012-01-05 11:26 ` Peter Korsgaard
2012-01-09 2:49 ` Florian Tobias Schandinat [this message]
2012-01-09 6:15 ` Peter Korsgaard
2012-01-09 13:36 ` Nicolas Ferre
2012-01-09 10:34 ` Nicolas Ferre
2012-01-09 11:13 ` Peter Korsgaard
2012-01-09 13:32 ` Nicolas Ferre
2012-01-10 13:01 ` Christian Glindkamp
2012-01-10 13:17 ` Peter Korsgaard
2012-01-10 16:42 ` Peter Korsgaard
2012-01-10 14:02 ` Jamie Lokier
2012-01-10 14:19 ` Peter Korsgaard
2012-01-10 21:06 ` Russell King - ARM Linux
2012-01-09 12:13 ` Russell King - ARM Linux
2012-01-09 12:20 ` Peter Korsgaard
2012-01-30 5:12 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0A55D7.50707@gmx.de \
--to=florianschandinat@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).