linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/15] ARM: plat-versatile: convert to twd_local_timer_register() interface
Date: Thu, 12 Jan 2012 11:53:27 +0000	[thread overview]
Message-ID: <4F0EC9B7.6040907@arm.com> (raw)
In-Reply-To: <20120112091426.GH1068@n2100.arm.linux.org.uk>

On 12/01/12 09:14, Russell King - ARM Linux wrote:
> On Wed, Jan 11, 2012 at 01:08:45PM +0000, Marc Zyngier wrote:
>> Add support for the new smp_twd runtime registration interface
>> to the RealView/VE platforms, and remove the old compile-time support.
>> Tested on EB11MP.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>> ---
>>  arch/arm/mach-realview/realview_eb.c     |   34 ++++++++++++++++++++++++++---
>>  arch/arm/mach-realview/realview_pb11mp.c |   32 ++++++++++++++++++++++++---
>>  arch/arm/mach-realview/realview_pbx.c    |   31 ++++++++++++++++++++++++--
>>  arch/arm/mach-vexpress/ct-ca9x4.c        |   30 +++++++++++++++++++++++--
>>  arch/arm/plat-versatile/Makefile         |    1 -
>>  arch/arm/plat-versatile/localtimer.c     |   27 -----------------------
>>  6 files changed, 113 insertions(+), 42 deletions(-)
>>  delete mode 100644 arch/arm/plat-versatile/localtimer.c
>>
>> diff --git a/arch/arm/mach-realview/realview_eb.c b/arch/arm/mach-realview/realview_eb.c
>> index e629621..6c5e61d 100644
>> --- a/arch/arm/mach-realview/realview_eb.c
>> +++ b/arch/arm/mach-realview/realview_eb.c
>> @@ -36,7 +36,7 @@
>>  #include <asm/pgtable.h>
>>  #include <asm/hardware/gic.h>
>>  #include <asm/hardware/cache-l2x0.h>
>> -#include <asm/localtimer.h>
>> +#include <asm/smp_twd.h>
>>  
>>  #include <asm/mach/arch.h>
>>  #include <asm/mach/map.h>
>> @@ -388,6 +388,34 @@ static void realview_eb11mp_fixup(void)
>>  	realview_eb_isp1761_resources[1].end	= IRQ_EB11MP_USB;
>>  }
>>  
>> +#ifdef CONFIG_HAVE_ARM_TWD
>> +static struct twd_local_timer twd_local_timer __initdata = {
>> +	.res =	{
>> +		{
>> +			.start	= REALVIEW_EB11MP_TWD_BASE,
>> +			.end	= REALVIEW_EB11MP_TWD_BASE + 0xff,
>> +			.flags	= IORESOURCE_MEM,
>> +		},
> 
> DEFINE_RES_MEM() ?
> 
>> +		{
>> +			.start	= IRQ_LOCALTIMER,
>> +			.end	= IRQ_LOCALTIMER,
>> +			.flags	= IORESOURCE_IRQ,
>> +		},
> 
> DEFINE_RES_IRQ() ?

Indeed. Actually, I'd like to have the following in smp_twd.h:
#define DEFINE_TWD_LOCAL_TIMER(name,base,irq)	\
struct twd_local_timer name __initdata = {	\
	.res	= {				\
		DEFINE_RES_MEM(base, 0x10),	\
		DEFINE_RES_IRQ(irq),		\
	},					\
};

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2012-01-12 11:53 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11 13:08 [PATCH 00/15] Runtime registration for local timers Marc Zyngier
2012-01-11 13:08 ` [PATCH 01/15] ARM: smp_twd: make local_timer_stop a symbol instead of a #define Marc Zyngier
2012-01-11 13:08 ` [PATCH 02/15] ARM: local timers: introduce a new registration interface Marc Zyngier
2012-01-11 13:08 ` [PATCH 03/15] ARM: smp_twd: add runtime registration support Marc Zyngier
2012-01-11 13:08 ` [PATCH 04/15] ARM: smp_twd: add device tree support Marc Zyngier
2012-01-11 21:05   ` Rob Herring
2012-01-12 14:36     ` Marc Zyngier
2012-01-12 15:42       ` Rob Herring
2012-01-12 16:00         ` Marc Zyngier
2012-01-12 16:27           ` Rob Herring
2012-01-12 17:58             ` Marc Zyngier
2012-01-11 13:08 ` [PATCH 05/15] ARM: OMAP4: convert to twd_local_timer_register() interface Marc Zyngier
2012-01-11 13:14   ` Shilimkar, Santosh
2012-01-11 13:08 ` [PATCH 06/15] ARM: plat-versatile: " Marc Zyngier
2012-01-12  9:14   ` Russell King - ARM Linux
2012-01-12 11:53     ` Marc Zyngier [this message]
2012-01-11 13:08 ` [PATCH 07/15] ARM: tegra: " Marc Zyngier
2012-01-11 21:49   ` Stephen Warren
2012-01-11 13:08 ` [PATCH 08/15] ARM: shmobile: " Marc Zyngier
2012-01-12  9:19   ` Russell King - ARM Linux
2012-01-12 11:24     ` Marc Zyngier
2012-01-12 12:00       ` Marc Zyngier
2012-01-11 13:08 ` [PATCH 09/15] ARM: ux500: " Marc Zyngier
2012-01-11 23:53   ` Linus Walleij
2012-01-12 13:59     ` Marc Zyngier
2012-01-14 11:43       ` Linus Walleij
2012-01-12  9:16   ` Russell King - ARM Linux
2012-01-12 10:55     ` Marc Zyngier
2012-01-11 13:08 ` [PATCH 10/15] ARM: highbank: " Marc Zyngier
2012-01-11 13:08 ` [PATCH 11/15] ARM: imx6q: " Marc Zyngier
2012-01-12  9:21   ` Shawn Guo
2012-01-11 13:08 ` [PATCH 12/15] ARM: smp_twd: remove old local timer interface Marc Zyngier
2012-01-11 13:08 ` [PATCH 13/15] ARM: local timers: convert exynos to runtime registration interface Marc Zyngier
2012-01-11 13:08 ` [PATCH 14/15] ARM: local timers: convert MSM " Marc Zyngier
2012-01-13  0:13   ` David Brown
2012-01-13  0:27     ` David Brown
2012-01-13 10:11       ` Marc Zyngier
2012-01-11 13:08 ` [PATCH 15/15] ARM: local timers: make the runtime registration interface mandatory Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0EC9B7.6040907@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).