From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Fri, 13 Jan 2012 10:29:49 +0100 Subject: [PATCH 5/7] at91 : fix dirty hack for the selfrefresh function In-Reply-To: References: <1326293740-15735-1-git-send-email-daniel.lezcano@linaro.org> <1326293740-15735-6-git-send-email-daniel.lezcano@linaro.org> <20120111165508.GC1068@n2100.arm.linux.org.uk> <201201111827.18890.arnd.bergmann@linaro.org> <20120111194334.GF1068@n2100.arm.linux.org.uk> <4F0EF119.3000605@atmel.com> <20120112193639.GL1068@n2100.arm.linux.org.uk> Message-ID: <4F0FF98D.9050308@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/13/2012 01:38 AM, Rob Lee wrote: > On Thu, Jan 12, 2012 at 1:36 PM, Russell King - ARM Linux > wrote: > >> Okay, that makes sense (because everything but rm9200 branches out to >> one of the cpu idle functions.) >> >> It also supports my second idea described in >> http://lists.arm.linux.org.uk/lurker/message/20120109.144443.3626e5a6.en.html >> See the paragraph starting "So, what I suggest instead" at that URL and >> following text. >> >> The reason I think this is the best solution is: >> (a) we move the CPU dependencies into each CPU file >> (b) we localize the quirks needed for each CPU into its own specific code >> (c) we can select at run time between the various standby functions >> >> These are all AT91 specific wins. What it also gets us is _much_ less >> exported code from arch/arm/mach-at91 when the CPU idle stuff moves out, >> reducing it down to just a mere function pointer, and, because the AT91 >> specific idle stuff is hidden behind this it potentially opens the door >> towards some consolidation in this area between different SoCs. > > Apologies if this is a dumb question, but for the arch/arm/mach-at91 > function pointer that needs to be exported, what is the recommended > method for exporting it to a file that needs it in drivers/cpuidle? I was asking me the same question. I am wondering if that makes sense to create an arch/arm/include/asm/pm.h file where we move from the system.h file these two functions: extern void (*arm_pm_restart)(char str, const char *cmd); extern void (*arm_pm_idle)(void); and we add: extern void (*arm_pm_standby)(void); - -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPD/mNAAoJEAKBbMCpUGYAHFAH/0yXlX49BUW1nDqZPiP777tc rEajf5vD2lvvDzF3aeqmwfxLhNKBkppeasxFX8KCukQGq4SmDgC34NSbHAKi3SqX /Yv3xcWEPqnp3PgPacNCFX7kGqHIr9XWHjG/p38+82rGCOgtWn0DslOuzFa5JlJu ih2Yh+2hh2low4h/21no8rF08EJefh0PuMn1c58Jg04txe8iATpXZHU9ujeIlvUg NdHr8q1gzfGsnFb1gV26NHapERLwCJlj2ilttYMnNyHZYxTssDrnI4HsMDcyjcEQ 0BQYV0VMAHGSPiv9AIMx0ykCwQrjuDZPBEJIFS0ReZ1ItcGwVFFEmqb9X+OdJdg= =g+rR -----END PGP SIGNATURE-----