From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] dmaengine/dw_dmac: Add support for DMA_SLAVE_CONFIG
Date: Mon, 16 Jan 2012 17:12:29 +0530 [thread overview]
Message-ID: <4F140D25.1000309@st.com> (raw)
In-Reply-To: <7c1e6fd573d5cd348b22f8363c9960fe5efcd658.1326707233.git.viresh.kumar@st.com>
On 1/16/2012 3:20 PM, Viresh KUMAR wrote:
> + /*
> + * Fix sconfig's burst size according to dw_dmac. We need to convert
> + * them as: 1 -> 0, 2 -> 1, 4 -> 2, 8 -> 3, 16 -> 4.
> + *
> + * This can be done by findiding least significant bit set: n & (n - 1)
> + */
> + sconfig->src_maxburst &= sconfig->src_maxburst - 1;
> + sconfig->dst_maxburst &= sconfig->dst_maxburst - 1;
Perhaps, this looks incorrect. It will always return 0. :(
Can somebody suggest any inbuild function to do this, i think
find_next_bit(sconfig->src_maxburst, sizeof(sconfig->src_maxburst), 0)
will do it.
--
viresh
next prev parent reply other threads:[~2012-01-16 11:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 9:50 [PATCH 0/9] dmaengine: Pl08x and dw_dmac updates Viresh Kumar
2012-01-16 9:50 ` [PATCH 1/8] dmaengine/dw_dmac: Hibernation support in dw_dmac Viresh Kumar
2012-01-16 9:50 ` [PATCH 2/8] dmaengine: Add flow controller information to dma_slave_config Viresh Kumar
2012-01-17 8:37 ` Linus Walleij
2012-01-17 9:07 ` Viresh Kumar
2012-01-18 10:36 ` Linus Walleij
2012-01-18 10:40 ` Viresh Kumar
2012-01-16 9:50 ` [PATCH 3/8] dmaengine/amba-pl08x: Take flow controller info from DMA_SLAVE_CONFIG Viresh Kumar
2012-01-16 9:50 ` [PATCH 4/8] dmaengine/dw_dmac: Don't use magic number for total number of channels Viresh Kumar
2012-01-16 9:50 ` [PATCH 5/8] dmaengine/dw_dmac: Use platform_get_drvdata instead of accessing dev directly Viresh Kumar
2012-01-16 10:47 ` Sergei Shtylyov
2012-01-16 10:52 ` Viresh Kumar
2012-01-16 9:50 ` [PATCH 6/8] dmaengine/dw_dmac: Don't handle block interrupts Viresh Kumar
2012-01-16 9:50 ` [PATCH 7/8] dmaengine/dw_dmac: Unmap all memory buffers after completion of slave transfers Viresh Kumar
2012-01-16 10:54 ` Russell King - ARM Linux
2012-01-16 11:44 ` Viresh Kumar
2012-01-17 8:52 ` Linus Walleij
2012-01-17 9:07 ` Viresh Kumar
2012-01-18 9:35 ` Russell King - ARM Linux
2012-01-19 17:34 ` Linus Walleij
2012-01-16 9:50 ` [PATCH 8/8] dmaengine/dw_dmac: Add support for DMA_SLAVE_CONFIG Viresh Kumar
2012-01-16 11:42 ` Viresh Kumar [this message]
2012-01-17 8:49 ` Linus Walleij
2012-01-17 9:15 ` Viresh Kumar
2012-01-17 9:19 ` Viresh Kumar
2012-01-17 10:19 ` Viresh Kumar
2012-01-17 10:10 ` Jassi Brar
2012-01-17 10:19 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F140D25.1000309@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).