From mboxrd@z Thu Jan 1 00:00:00 1970 From: sylvester.nawrocki@gmail.com (Sylwester Nawrocki) Date: Mon, 23 Jan 2012 21:35:12 +0100 Subject: [RFC PATCH 5/7] ARM: davinci: i2c: add OF support In-Reply-To: <1327308967-8092-6-git-send-email-hs@denx.de> References: <1327308967-8092-1-git-send-email-hs@denx.de> <1327308967-8092-6-git-send-email-hs@denx.de> Message-ID: <4F1DC480.4010603@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On 01/23/2012 09:56 AM, Heiko Schocher wrote: > add of support for the davinci i2c driver. > > Signed-off-by: Heiko Schocher > Cc: davinci-linux-open-source at linux.davincidsp.com > Cc: linux-arm-kernel at lists.infradead.org > Cc: devicetree-discuss at lists.ozlabs.org > Cc: linux-i2c at vger.kernel.org > Cc: Ben Dooks > Cc: Wolfram Sang > Cc: Grant Likely > Cc: Sekhar Nori > Cc: Wolfgang Denk > --- > .../devicetree/bindings/arm/davinci/i2c.txt | 39 ++++++++++++++++++ > drivers/i2c/busses/i2c-davinci.c | 43 ++++++++++++++++++++ > 2 files changed, 82 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/arm/davinci/i2c.txt > > diff --git a/Documentation/devicetree/bindings/arm/davinci/i2c.txt b/Documentation/devicetree/bindings/arm/davinci/i2c.txt > new file mode 100644 > index 0000000..94ec670 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/davinci/i2c.txt > @@ -0,0 +1,39 @@ > +* Texas Instruments Davinci I2C > + > +This file provides information, what the device node for the > +davinci i2c interface contain. > + > +Required properties: > +- compatible: "ti,davinci-i2c"; > +- reg : Offset and length of the register set for the device > +- id: id of the controller I was wondering whether we're supposed to use "cell-index" property name for such a device instance index? or doesn't it really matter and "id" is fine? Such an IP instance index seems quite common so I thought it could be easier to follow to use standard name. -- Regards, Sylwester