From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: OMAP2+: PM: clean up omap_set_pwrdm_state()
Date: Tue, 31 Jan 2012 09:16:56 +0530 [thread overview]
Message-ID: <4F276430.2020406@ti.com> (raw)
In-Reply-To: <20120130094317.11027.82072.stgit@dusk>
Hi Paul,
On Monday 30 January 2012 03:13 PM, Paul Walmsley wrote:
> Clean up a few different parts of omap_set_pwrdm_state():
>
> - Remove a superfluous call to pwrdm_state_switch(). Not needed
> unless LOWPOWERSTATECHANGE is used, because the state switch code is
> called by either clkdm_sleep() or clkdm_allow_idle().
>
> - Add code to wait for the power state transition in the OMAP4+ low
> power state change. This is speculative, so I would particularly
> appreciate feedback on this part.
>
> - Remove a superfluous call to pwrdm_read_pwrst().
>
> - Update variable names to be more meaningful (hopefully) and precise.
>
> - Fix an error path bug that would not place the clockdomain back into
> hardware-supervised idle or sleep mode if the power state could not
> be programmed.
All the changes look good. Thanks.
Acked-by: Rajendra Nayak <rnayak@ti.com>
regards,
Rajendra
>
next prev parent reply other threads:[~2012-01-31 3:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 9:43 [PATCH 0/2] ARM: OMAP2+: PM: miscellaneous powerdomain-related improvements Paul Walmsley
2012-01-30 9:43 ` [PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst() Paul Walmsley
2012-01-30 10:54 ` Shilimkar, Santosh
2012-01-31 0:14 ` Kevin Hilman
2012-01-31 3:53 ` Rajendra Nayak
2012-01-31 6:57 ` Shilimkar, Santosh
2012-01-31 7:15 ` Paul Walmsley
2012-01-31 7:23 ` Shilimkar, Santosh
2012-01-31 7:27 ` Paul Walmsley
2012-01-31 7:34 ` Shilimkar, Santosh
2012-01-31 7:49 ` Paul Walmsley
2012-01-31 8:37 ` Shilimkar, Santosh
2012-01-31 17:29 ` Kevin Hilman
2012-02-01 19:27 ` Paul Walmsley
2012-02-02 7:13 ` Shilimkar, Santosh
2012-02-02 8:33 ` Paul Walmsley
2012-02-02 8:59 ` Shilimkar, Santosh
2012-02-02 10:05 ` Paul Walmsley
2012-02-02 10:17 ` Shilimkar, Santosh
2012-02-02 15:24 ` Shilimkar, Santosh
2012-02-02 19:59 ` Paul Walmsley
2012-02-02 18:14 ` Kevin Hilman
2012-01-30 9:43 ` [PATCH 2/2] ARM: OMAP2+: PM: clean up omap_set_pwrdm_state() Paul Walmsley
2012-01-30 12:17 ` Shilimkar, Santosh
2012-01-31 3:46 ` Rajendra Nayak [this message]
2012-01-30 21:27 ` [PATCH 0/2] ARM: OMAP2+: PM: miscellaneous powerdomain-related improvements Kevin Hilman
2012-01-31 7:21 ` Tero Kristo
2012-02-01 13:55 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F276430.2020406@ti.com \
--to=rnayak@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).