linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: srivatsa.bhat@linux.vnet.ibm.com (Srivatsa S. Bhat)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/12] arch/arm: remove references to cpu_*_map.
Date: Wed, 15 Feb 2012 14:48:36 +0530	[thread overview]
Message-ID: <4F3B786C.2080809@linux.vnet.ibm.com> (raw)
In-Reply-To: <1329281884.28702.rusty@rustcorp.com.au>

On 02/15/2012 10:28 AM, Rusty Russell wrote:

> From: Rusty Russell <rusty@rustcorp.com.au>
> 
> This has been obsolescent for a while; time for the final push.
> 
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: linux-arm-kernel at lists.infradead.org
> ---

[...]

> diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
> --- a/arch/arm/kernel/smp.c
> +++ b/arch/arm/kernel/smp.c
> @@ -359,7 +359,7 @@ void __init smp_prepare_cpus(unsigned in
>  		 * re-initialize the map in platform_smp_prepare_cpus() if
>  		 * present != possible (e.g. physical hotplug).
>  		 */
> -		init_cpu_present(&cpu_possible_map);
> +		init_cpu_present(cpu_possible_mask);
>  
>  		/*
>  		 * Initialise the SCU if there are more than one CPU
> @@ -577,8 +577,9 @@ void smp_send_stop(void)
>  	unsigned long timeout;
>  
>  	if (num_online_cpus() > 1) {
> -		cpumask_t mask = cpu_online_map;
> -		cpu_clear(smp_processor_id(), mask);
> +		struct cpumask mask;
> +		cpumask_copy(&mask, cpu_online_mask);
> +		cpumask_clear_cpu(&mask, smp_processor_id());
>  


This should be the other way around:
		cpumask_clear_cpu(smp_processor_id(), &mask);

>  		smp_cross_call(&mask, IPI_CPU_STOP);
>  	}
> 


Regards,
Srivatsa S. Bhat

      reply	other threads:[~2012-02-15  9:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15  4:58 [PATCH 2/12] arch/arm: remove references to cpu_*_map Rusty Russell
2012-02-15  9:18 ` Srivatsa S. Bhat [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3B786C.2080809@linux.vnet.ibm.com \
    --to=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).