From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: need to include asm/system.h in asm/processor.h
Date: Wed, 15 Feb 2012 14:06:41 -0600 [thread overview]
Message-ID: <4F3C1051.7010404@gmail.com> (raw)
In-Reply-To: <20120215195927.GA31373@codeaurora.org>
On 02/15/2012 01:59 PM, David Brown wrote:
> On Wed, Feb 15, 2012 at 11:20:10AM -0800, Olof Johansson wrote:
>> For files that include asm/processor.h but not asm/system.h:
>>
>> arch/arm/mach-msm/include/mach/uncompress.h: In function 'putc':
>> arch/arm/mach-msm/include/mach/uncompress.h:48:3: error: implicit declaration of function 'smp_mb' [-Werror=implicit-function-declaration]
>>
>> In this case, smp_mb() is from the cpu_relax() call in the msm putc().
>>
>> It likely went uncaught when the uncompress.h change went in since the
>> defconfig didn't enable that code path, but later changes (e76f4750f4:
>> ARM: debug: arrange Kconfig options more logically) resulted in the
>> option being on for msm_defconfig and thus exposed it.
>>
>> Signed-off-by: Olof Johansson <olof@lixom.net>
>
> BTW, Rob Herring has this same patch in his io.h cleanup patches, so
> it's probably best to coordinate with him.
I'd just assumed that I had broken things by implicitly dropping a lot
of includes when removing mach/io.h. Go ahead and apply yours and I'll
drop mine.
Rob
> Author: Rob Herring <rob.herring@calxeda.com>
> Date: Mon Feb 13 15:43:15 2012 -0600
>
> ARM: add explicit include of system.h to processor.h
>
> cpu_relax in processor.h needs smp_mb which is defined in
> system.h.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
>
> David
>
next prev parent reply other threads:[~2012-02-15 20:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 19:20 [PATCH] ARM: need to include asm/system.h in asm/processor.h Olof Johansson
2012-02-15 19:59 ` David Brown
2012-02-15 20:06 ` Rob Herring [this message]
2012-02-15 20:12 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3C1051.7010404@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).