linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ffainelli@freebox.fr (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd :  change the location of the ONFI detected log
Date: Fri, 17 Feb 2012 09:47:35 +0100	[thread overview]
Message-ID: <4F3E1427.4080502@freebox.fr> (raw)
In-Reply-To: <1329448957-9756-1-git-send-email-b32955@freescale.com>

Le 02/17/12 04:22, Huang Shijie a ?crit :
> Some strange nand chip(such as Hynix H27UBG8T2A) can pass the `ONFI` signature
> check. So the log can be printed out even it is not an ONFI nand indeed.
>
> Change this log to the end of the function. Print out the log only when we
> really detect an ONFI nand.
>
> Signed-off-by: Huang Shijie<b32955@freescale.com>

Acked-by: Florian Fainelli <ffainelli@freebox.fr>

> ---
>   drivers/mtd/nand/nand_base.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 5822e3a..1e907dc 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -2853,7 +2853,6 @@ static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip,
>   		chip->read_byte(mtd) != 'F' || chip->read_byte(mtd) != 'I')
>   		return 0;
>
> -	pr_info("ONFI flash detected\n");
>   	chip->cmdfunc(mtd, NAND_CMD_PARAM, 0, -1);
>   	for (i = 0; i<  3; i++) {
>   		chip->read_buf(mtd, (uint8_t *)p, sizeof(*p));
> @@ -2903,6 +2902,7 @@ static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip,
>   	chip->options |= (NAND_NO_READRDY |
>   			NAND_NO_AUTOINCR)&  NAND_CHIPOPTIONS_MSK;
>
> +	pr_info("ONFI flash detected\n");
>   	return 1;
>   }
>

  reply	other threads:[~2012-02-17  8:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-17  3:22 [PATCH] mtd : change the location of the ONFI detected log Huang Shijie
2012-02-17  8:47 ` Florian Fainelli [this message]
2012-02-18  5:46 ` Brian Norris
2012-02-29 15:08 ` Bityutskiy, Artem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3E1427.4080502@freebox.fr \
    --to=ffainelli@freebox.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).