From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.ujfalusi@ti.com (Peter Ujfalusi) Date: Mon, 20 Feb 2012 10:04:05 +0200 Subject: [RFC 00/11]O MAP/ASoC: Move and merge McBSP driver under ASoC In-Reply-To: References: <1329320246-1548-1-git-send-email-peter.ujfalusi@ti.com> Message-ID: <4F41FE75.4070003@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Gra?vydas, On 02/18/2012 11:43 PM, Grazvydas Ignotas wrote: > On Wed, Feb 15, 2012 at 5:37 PM, Peter Ujfalusi wrote: >> Comments, testers are welcome... > > Tried these on current mainline and they break sound on pandora: > # aplay /dev/urandom > Playing raw data '/dev/urandom' : Unsigned 8 bit, Rate 8000 Hz, Mono > [ 81.306304] omap-mcbsp: clks: could not clk_set_parent() to pad_fck > [ 81.313110] ASoC omap3pandora: can't set cpu system clock > [ 81.319244] asoc: machine hw_params failed > aplay: set_params:1022: Unable to install hw params: > > I've retried without these patches to confirm it works like that, and it did. Thanks for testing the series. The issue is that I forgot to remove the pm_runtime_put/get_sync calls from the moved mcbsp.c file. Can you manually remove these calls from sound/soc/omap/mcbsp.c ? It will fix the issue I believe. I will update the series. -- P?ter