From mboxrd@z Thu Jan 1 00:00:00 1970 From: b-cousson@ti.com (Cousson, Benoit) Date: Fri, 24 Feb 2012 15:35:44 +0100 Subject: [PATCH 2/3] tty: serial: OMAP: block idle while the UART is transferring data in PIO mode In-Reply-To: References: <20120126024903.31613.24730.stgit@dusk> <20120126025036.31613.67819.stgit@dusk> <4F423E28.3040404@ti.com> Message-ID: <4F47A040.6030502@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Salut Paul, On 2/21/2012 11:02 PM, Paul Walmsley wrote: > Salut Beno?t, > > On Mon, 20 Feb 2012, Cousson, Benoit wrote: > >> 3.3-rc4 is broken in the DT case because of the serial driver. And it >> looks like it is due to this fix. We cannot rely on pdata anymore in >> DT, and in that case it leads to an Oops due to NULL pdata. > > Sorry about the breakage. I agree with the diagnosis. That code was just > copied from the DMA errata part of the driver, so it will need to be fixed > as well. Otherwise the same problem will happen when DMA is enabled. > >> And then we will have to add the support for all these OMAP custom hooks without pdata. > > That's really the key question for the medium- to long-term... I know you know, I'm always hoping that someone will step up and propose some cool idea to fix that :-) >> A basic fix (below) for the moment is to test for valid pdata inside the driver. >> I'll repost it properly if you are fine with it. > > Looks fine to me, although I'd suggest fixing the DMA workaround path as > well. Mmm, I've tried to fix every instances of pdata in the code, you think I missed some? I'll check again. > Reviewed-by: Paul Walmsley Thanks, Benoit