From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] USB: Support for LPC32xx SoC
Date: Sat, 25 Feb 2012 15:03:46 +0100 [thread overview]
Message-ID: <4F48EA42.70408@antcom.de> (raw)
In-Reply-To: <20120225035128.GA4455@pengutronix.de>
On 25/02/12 04:51, Wolfram Sang wrote:
>> Unfortunately, the way that ohci handles the abstraction between
>> the various implementations is backwards, it would be much easier
>> if the main driver was following that model to start with.
>
> ... exactly for that reason I didn't suggest it. Looking at other
> ohci-sources (e.g. ohci-omap.c), machine_is_* seems to be the
> consistent use-case.
OK, considering this, I for now used machine_is_*() to get rid of the
#ifdefs.
Using platform_device_id.driver_data as Arnd suggested is also a good
idea, and switching to it will be easy when it is due.
Thanks in advance,
Roland
prev parent reply other threads:[~2012-02-25 14:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 20:57 [PATCH v2] USB: Support for LPC32xx SoC Roland Stigge
2012-02-23 21:05 ` Roland Stigge
2012-02-24 6:35 ` Wolfram Sang
2012-02-24 15:03 ` Arnd Bergmann
2012-02-25 3:51 ` Wolfram Sang
2012-02-25 8:45 ` Arnd Bergmann
2012-02-25 15:46 ` Alan Stern
2012-02-26 10:01 ` Arnd Bergmann
2012-02-26 15:59 ` Alan Stern
2012-02-27 14:03 ` Arnd Bergmann
2012-02-27 16:42 ` Alan Stern
2012-02-27 22:01 ` Arnd Bergmann
2012-02-28 15:01 ` Alan Stern
2012-02-28 15:53 ` Arnd Bergmann
2012-02-28 16:51 ` Alan Stern
2012-02-25 14:03 ` Roland Stigge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F48EA42.70408@antcom.de \
--to=stigge@antcom.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).