From mboxrd@z Thu Jan 1 00:00:00 1970 From: robherring2@gmail.com (Rob Herring) Date: Sun, 26 Feb 2012 21:42:13 -0600 Subject: [PATCH] ARM: integrator: convert to sparse irqs In-Reply-To: References: <1330104737-22782-1-git-send-email-linus.walleij@linaro.org> <20120224191541.GB21556@game.jcrosoft.org> Message-ID: <4F4AFB95.9040204@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/26/2012 03:45 AM, Linus Walleij wrote: > On Fri, Feb 24, 2012 at 8:15 PM, Jean-Christophe PLAGNIOL-VILLARD > wrote: >> On 18:32 Fri 24 Feb , Linus Walleij wrote: > >>> -#define NR_IRQS 47 >>> +#define NR_IRQS_INTEGRATOR_AP 34 >>> +#define NR_IRQS_INTEGRATOR_CP 47 >> >> why do you need to specified both? > > They are two totally different machines and should never have had that > common roof of NR_IRQS = max(AP,CP), it's just not elegant. > > Maybe I'm a bit pedantic but I want to set the .nr_irqs for each machine so that > it corresponds exactly to what it actually has, instead of using a roof value. > I think it improves readability and understanding. > Really, you want to get rid of the value altogether. Each irq_chip should allocate its irq_descs and then you don't need to set .nr_irqs. Rob > Yours > Linus Walleij