From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] arm/dts: OMAP3: Add mmc controller nodes and board data
Date: Fri, 09 Mar 2012 14:56:07 +0530 [thread overview]
Message-ID: <4F59CCAF.1090806@ti.com> (raw)
In-Reply-To: <20120309054608.647473E0901@localhost>
On Friday 09 March 2012 11:16 AM, Grant Likely wrote:
> On Fri, 24 Feb 2012 10:49:00 -0800, Tony Lindgren<tony@atomide.com> wrote:
>> * Rajendra Nayak<rnayak@ti.com> [120223 19:29]:
>>> On Friday 24 February 2012 12:27 AM, Tony Lindgren wrote:
>>>>> --- a/arch/arm/boot/dts/omap3.dtsi
>>>>> +++ b/arch/arm/boot/dts/omap3.dtsi
>>>>> @@ -113,5 +113,31 @@
>>>>> #size-cells =<0>;
>>>>> ti,hwmods = "i2c3";
>>>>> };
>>>>> +
>>>>> + mmc1: mmc at 1 {
>>>>> + compatible = "ti,omap2-hsmmc";
>>>>> + ti,hwmods = "mmc1";
>>>>> + ti,dual-volt;
>>>>> + };
>>>>> +
>>>>> + mmc2: mmc at 2 {
>>>>> + compatible = "ti,omap2-hsmmc";
>>>>> + ti,hwmods = "mmc2";
>>>>> + };
>>>>> +
>>>>> + mmc3: mmc at 3 {
>>>>> + compatible = "ti,omap2-hsmmc";
>>>>> + ti,hwmods = "mmc3";
>>>>> + };
>>>>> +
>>>>> + mmc4: mmc at 4 {
>>>>> + compatible = "ti,omap2-hsmmc";
>>>>> + ti,hwmods = "mmc4";
>>>>> + };
>>>>> +
>>>>> + mmc5: mmc at 5 {
>>>>> + compatible = "ti,omap2-hsmmc";
>>>>> + ti,hwmods = "mmc5";
>>>>> + };
>>>>> };
>>>>> };
>>>>
>>>> These all should all be "ti,omap3-hsmmc" I guess?
>>>
>>> Well, I defined the binding such that both omap2 and omap3
>>> can use the same compatible "ti,omap2-hsmmc" since there is
>>> no difference in the way they are defined or handled. If thats
>>> confusing, I can have separate compatibles.
>>> Btw, I guess we do the same with a few other re-used IPs as well,
>>> I just checked and mcpsi does the same.
>>
>> Yeah let's use separate compatibles to avoid confusion.
>> For omap2 we also have the ti,omap2-mmc in addition to
>> ti,omap2-hsmmc..
>
> Yes, absolutely use separate compatible values. It is always important
> to be specific as to the silicon implementing the IP. The omap3 instance
> can also carry the omap2 string in its compatible list:
>
> compatible = "ti,omap3-hsmmc", "ti,omap2-hsmmc";
Sure, will repost with seperate compatible strings. Also missed adding
the 'status = "disable";' for unused mmc blocks in the board .dts file
causing unused mmc modules to get probed too. Will fix that as well.
thanks,
Rajendra
>
> g.
next prev parent reply other threads:[~2012-03-09 9:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 12:01 [PATCH v2 0/4] omap hsmmc device tree support Rajendra Nayak
2012-02-23 12:01 ` [PATCH v2 1/4] mmc: omap_hsmmc: Convert hsmmc driver to use device tree Rajendra Nayak
2012-02-24 11:32 ` T Krishnamoorthy, Balaji
2012-02-24 11:35 ` Rajendra Nayak
2012-02-24 12:51 ` Cousson, Benoit
2012-02-24 12:58 ` Rajendra Nayak
2012-02-24 13:02 ` Cousson, Benoit
2012-02-24 13:04 ` Rajendra Nayak
2012-03-08 3:46 ` Rajendra Nayak
2012-03-08 15:58 ` Rob Herring
2012-03-09 5:42 ` Grant Likely
2012-03-09 9:21 ` Rajendra Nayak
2012-02-23 12:01 ` [PATCH v2 2/4] mmc: omap_hsmmc: Avoid a regulator voltage change with dt Rajendra Nayak
2012-02-23 12:01 ` [PATCH v2 3/4] arm/dts: OMAP4: Add mmc controller nodes and board data Rajendra Nayak
2012-02-24 10:16 ` T Krishnamoorthy, Balaji
2012-02-24 10:26 ` Rajendra Nayak
2012-02-24 10:37 ` Russell King - ARM Linux
2012-02-24 10:59 ` T Krishnamoorthy, Balaji
2012-03-09 15:49 ` Grant Likely
2012-02-23 12:01 ` [PATCH v2 4/4] arm/dts: OMAP3: " Rajendra Nayak
2012-02-23 18:57 ` Tony Lindgren
2012-02-24 4:00 ` Rajendra Nayak
2012-02-24 11:23 ` Cousson, Benoit
2012-02-24 18:49 ` Tony Lindgren
2012-03-09 5:46 ` Grant Likely
2012-03-09 6:51 ` Paul Walmsley
2012-03-09 9:36 ` Rajendra Nayak
2012-03-09 9:26 ` Rajendra Nayak [this message]
2012-02-23 12:13 ` [PATCH v2 0/4] omap hsmmc device tree support Rajendra Nayak
-- strict thread matches above, loose matches on Subject: below --
2012-03-12 15:02 Rajendra Nayak
2012-03-12 15:02 ` [PATCH v2 4/4] arm/dts: OMAP3: Add mmc controller nodes and board data Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F59CCAF.1090806@ti.com \
--to=rnayak@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).