From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] Samsung board stuff for v3.4
Date: Sun, 11 Mar 2012 00:02:30 -0800 [thread overview]
Message-ID: <4F5C5C16.6020106@samsung.com> (raw)
In-Reply-To: <CAOesGMjiYDFhkjS=2e+3YdPJHExupt3Wm_NS3x1XW-17eEZM=A@mail.gmail.com>
On 03/10/12 09:45, Olof Johansson wrote:
> Hi,
>
> On Sat, Mar 10, 2012 at 7:34 AM, Kukjin Kim<kgene.kim@samsung.com> wrote:
>> Hi Arnd, Olof,
>>
>> Please pull regarding Samsung board patches for v3.4.
>>
>> Most are enabling some features(IPs) on each board and
>> one is adding new board file, Samsung Mobile's TRATS board.
>
> Given that exynos has started conversion to device tree, there should
> not be any additions of non-devicetree-probed board files being
> added.
>
> At the very least, you should move over to using DT_MACHINE instead of
> MACHINE for the new board, and probe using device tree. Even better
> would be if you added support for this board through mach-exynos4-dt.c
> instead of adding a brand new board file.
>
> I also see a large number of the same additions of devices, done to a
> number of board files. I don't think you need to rework those patches
> now, but please consider how you can make it less "churny" to add a
> device on the SoC in the future without touching all board files.
>
>
> If you rebase without the board file addition I can take the rest of
> the branch while that part is being reworked. Please send a new pull
> request with the rebased tree.
>
OK, I see. let me send a new pull request soon as per your suggestion.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2012-03-11 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-10 15:34 [GIT PULL] Samsung board stuff for v3.4 Kukjin Kim
2012-03-10 17:45 ` Olof Johansson
2012-03-11 8:02 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5C5C16.6020106@samsung.com \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox