From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd/gpmi : fix the wrong DMA command.
Date: Mon, 12 Mar 2012 16:35:13 +0800 [thread overview]
Message-ID: <4F5DB541.3000107@freescale.com> (raw)
In-Reply-To: <20120312075107.GB3928@pengutronix.de>
? 2012?03?12? 15:51, Wolfram Sang ??:
> On Mon, Mar 12, 2012 at 10:22:18AM +0800, Huang Shijie wrote:
>> The last DMA command of ECC read page is used to disable the BCH module.
>> But the original code missed to set the pio[2] which is used to set the
>> GPMI_HW_GPMI_ECCCTRL register. fix it now.
>>
>> Signed-off-by: Huang Shijie <b32955@freescale.com>
> Thanks! What does happen because of this bug? Additional checksum errors? I
> haven't seen many on MX28 IIRC, so I wonder.
>
The MX28 runs well without this patch. I guess the speed of mx28 is too
slow.
The bug only observed in mx6q. A DMA timeout occurs.
But if you apply this patch to mx28's code. A dma timeout occurs too.
This is why i sent the patch
"mxs-dma : rewrite the last parameter of mxs_dma_prep_slave_sg()"
IC guy told me to add a WAIT4END in the middle one of the ECC read page
chain, and disable the BCH in the last
DMA command of the chain. After this patch, the code follows this rule.
BR
Huang Shijie
next prev parent reply other threads:[~2012-03-12 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 2:22 [PATCH] mtd/gpmi : fix the wrong DMA command Huang Shijie
2012-03-12 7:51 ` Wolfram Sang
2012-03-12 8:35 ` Huang Shijie [this message]
2012-03-13 12:33 ` Bityutskiy, Artem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5DB541.3000107@freescale.com \
--to=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).