linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards
Date: Thu, 15 Mar 2012 14:30:27 +0530	[thread overview]
Message-ID: <4F61AFAB.6080301@st.com> (raw)
In-Reply-To: <201203150948.27918.sr@denx.de>

On 3/15/2012 2:18 PM, Stefan Roese wrote:
>>> > > +static const struct of_device_id vic_of_match[] __initconst = {
>>> > > +	{ .compatible = "arm,pl190-vic", .data = vic_of_init, },
>>> > > +	{ /* Sentinel */ }
>>> > > +};
>>> > > +
>>> > > +static void __init spear6xx_dt_init_irq(void)
>>> > > +{
>>> > > +	of_irq_init(vic_of_match);
>>> > > +}
>>> > > +
>> > 
>> > What about adding this routine in vic.c file, which can then be used
>> > by all platforms, instead of replicating this code.
> We can't move vic_of_match to the vic.c, since there are differences between 
> the boards using it. And only moving spear6xx_dt_init_irq() (renamed of 
> course) doesn't seem worth it.

I knew this. Actually my thought was, we have two compatible strings for vic:
pl190 and pl192.

So, create two vic_of_match* arrays and two vic*_dt_init_irq() routines.
That will solve the issue i believe.

-- 
viresh

  reply	other threads:[~2012-03-15  9:00 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13 14:47 [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards Stefan Roese
2012-03-13 16:44 ` Arnd Bergmann
2012-03-14  7:08   ` Viresh Kumar
2012-03-14  9:58     ` Arnd Bergmann
2012-03-14 10:02       ` Viresh Kumar
2012-03-14  7:40   ` Stefan Roese
2012-03-14  9:48     ` Arnd Bergmann
2012-03-14 10:36       ` Stefan Roese
2012-03-14 13:27         ` Arnd Bergmann
2012-03-14 13:43           ` Stefan Roese
2012-03-14 14:09             ` Arnd Bergmann
2012-03-14 13:44           ` Rob Herring
2012-03-14  7:05 ` Viresh Kumar
2012-03-14  7:20   ` Stefan Roese
2012-03-15  8:48   ` Stefan Roese
2012-03-15  9:00     ` Viresh Kumar [this message]
2012-03-15 10:38       ` Stefan Roese
2012-03-15 10:40         ` Viresh Kumar
2012-03-15 13:39         ` Arnd Bergmann
2012-03-21 11:32           ` Viresh Kumar
2012-03-21 12:36             ` Arnd Bergmann
2012-03-21 13:28               ` viresh kumar
2012-03-21 14:04                 ` Arnd Bergmann
2012-03-21 14:18                   ` viresh kumar
2012-03-21 14:42                     ` Arnd Bergmann
2012-03-21 18:26                   ` Arnd Bergmann
2012-03-22  0:45                     ` viresh kumar
2012-03-22  8:10                       ` Arnd Bergmann
     [not found]               ` <CAOh2x=k6ZfamB8DnPgVPjxZ7E1gTuHOQYg6s1Nd1ybA+TSquWA@mail.gmail.com>
2012-03-22 14:20                 ` Arnd Bergmann
2012-03-27 10:27                   ` Viresh Kumar
2012-03-27 11:15                     ` Arnd Bergmann
2012-03-27 11:27                       ` Viresh Kumar
2012-03-27 11:45                         ` Viresh Kumar
2012-03-27 11:59                         ` Arnd Bergmann
     [not found]                           ` <CAOh2x==7gNt2Jb3-EHz9-R1pTy6zL93FmUmTBMdpYUnW3F=9Uw@mail.gmail.com>
2012-03-27 13:59                             ` Arnd Bergmann
2012-03-28  5:03                               ` Viresh Kumar
2012-03-28  8:13                                 ` Arnd Bergmann
2012-03-14  8:48 ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F61AFAB.6080301@st.com \
    --to=viresh.kumar@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).