* [PATCH] drivers/base: fix compiler warning in SoC export driver - idr should be ida
@ 2012-03-17 9:01 Lee Jones
2012-03-17 9:04 ` Russell King - ARM Linux
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2012-03-17 9:01 UTC (permalink / raw)
To: linux-arm-kernel
Reported-by: Arnd Bergman <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/base/soc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/base/soc.c b/drivers/base/soc.c
index 05f1503..e57aec1 100644
--- a/drivers/base/soc.c
+++ b/drivers/base/soc.c
@@ -15,7 +15,7 @@
#include <linux/sys_soc.h>
#include <linux/err.h>
-static DEFINE_IDR(soc_ida);
+static DEFINE_IDA(soc_ida);
static DEFINE_SPINLOCK(soc_lock);
static ssize_t soc_info_get(struct device *dev,
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drivers/base: fix compiler warning in SoC export driver - idr should be ida
2012-03-17 9:01 [PATCH] drivers/base: fix compiler warning in SoC export driver - idr should be ida Lee Jones
@ 2012-03-17 9:04 ` Russell King - ARM Linux
2012-03-17 9:12 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Russell King - ARM Linux @ 2012-03-17 9:04 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Mar 17, 2012 at 09:01:10AM +0000, Lee Jones wrote:
If you're fixing a warning, please always include the warning in the
commit description.
> Reported-by: Arnd Bergman <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/base/soc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/base/soc.c b/drivers/base/soc.c
> index 05f1503..e57aec1 100644
> --- a/drivers/base/soc.c
> +++ b/drivers/base/soc.c
> @@ -15,7 +15,7 @@
> #include <linux/sys_soc.h>
> #include <linux/err.h>
>
> -static DEFINE_IDR(soc_ida);
> +static DEFINE_IDA(soc_ida);
> static DEFINE_SPINLOCK(soc_lock);
>
> static ssize_t soc_info_get(struct device *dev,
> --
> 1.7.5.4
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drivers/base: fix compiler warning in SoC export driver - idr should be ida
2012-03-17 9:04 ` Russell King - ARM Linux
@ 2012-03-17 9:12 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2012-03-17 9:12 UTC (permalink / raw)
To: linux-arm-kernel
On 17/03/12 09:04, Russell King - ARM Linux wrote:
> On Sat, Mar 17, 2012 at 09:01:10AM +0000, Lee Jones wrote:
>
> If you're fixing a warning, please always include the warning in the
> commit description.
No problem, thanks.
>> Reported-by: Arnd Bergman <arnd@arndb.de>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>> ---
>> drivers/base/soc.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/base/soc.c b/drivers/base/soc.c
>> index 05f1503..e57aec1 100644
>> --- a/drivers/base/soc.c
>> +++ b/drivers/base/soc.c
>> @@ -15,7 +15,7 @@
>> #include <linux/sys_soc.h>
>> #include <linux/err.h>
>>
>> -static DEFINE_IDR(soc_ida);
>> +static DEFINE_IDA(soc_ida);
>> static DEFINE_SPINLOCK(soc_lock);
>>
>> static ssize_t soc_info_get(struct device *dev,
>> --
>> 1.7.5.4
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drivers/base: fix compiler warning in SoC export driver - idr should be ida
@ 2012-03-17 9:17 Lee Jones
2012-03-17 21:16 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2012-03-17 9:17 UTC (permalink / raw)
To: linux-arm-kernel
This fixes:
note: expected ?struct ida *? but argument is of type ?struct idr *?
warning: passing argument 1 of ?ida_pre_get? from incompatible pointer type
Reported-by: Arnd Bergman <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/base/soc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/base/soc.c b/drivers/base/soc.c
index 05f1503..e57aec1 100644
--- a/drivers/base/soc.c
+++ b/drivers/base/soc.c
@@ -15,7 +15,7 @@
#include <linux/sys_soc.h>
#include <linux/err.h>
-static DEFINE_IDR(soc_ida);
+static DEFINE_IDA(soc_ida);
static DEFINE_SPINLOCK(soc_lock);
static ssize_t soc_info_get(struct device *dev,
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drivers/base: fix compiler warning in SoC export driver - idr should be ida
2012-03-17 9:17 Lee Jones
@ 2012-03-17 21:16 ` Arnd Bergmann
2012-03-29 13:46 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2012-03-17 21:16 UTC (permalink / raw)
To: linux-arm-kernel
On Saturday 17 March 2012, Lee Jones wrote:
>
> This fixes:
> note: expected ?struct ida *? but argument is of type ?struct idr *?
> warning: passing argument 1 of ?ida_pre_get? from incompatible pointer type
>
> Reported-by: Arnd Bergman <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> drivers/base/soc.c | 2 +-
Acked-by: Arnd Bergmann <arnd@arndb.de>
Greg, are you taking this through your tree?
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drivers/base: fix compiler warning in SoC export driver - idr should be ida
2012-03-17 21:16 ` Arnd Bergmann
@ 2012-03-29 13:46 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2012-03-29 13:46 UTC (permalink / raw)
To: linux-arm-kernel
On Saturday 17 March 2012, Arnd Bergmann wrote:
> On Saturday 17 March 2012, Lee Jones wrote:
> >
> > This fixes:
> > note: expected ?struct ida *? but argument is of type ?struct idr *?
> > warning: passing argument 1 of ?ida_pre_get? from incompatible pointer type
> >
> > Reported-by: Arnd Bergman <arnd@arndb.de>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> >
> > drivers/base/soc.c | 2 +-
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Greg, are you taking this through your tree?
I've applied it to arm-soc/fixes now. Greg, if you have any objections,
tell me before the weekend and I'll take it out again, otherwise I'll
submit it before -rc1.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-29 13:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-17 9:01 [PATCH] drivers/base: fix compiler warning in SoC export driver - idr should be ida Lee Jones
2012-03-17 9:04 ` Russell King - ARM Linux
2012-03-17 9:12 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2012-03-17 9:17 Lee Jones
2012-03-17 21:16 ` Arnd Bergmann
2012-03-29 13:46 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).